docs: use versioned links from docs to guide #4331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(It also fixes the |
LilyFirefly
approved these changes
Jul 10, 2024
| @@ -1,10 +1,10 @@ | |||
| error: #[pyclass] cannot have generic parameters. For an explanation, see https://pyo3.rs/latest/class.html#no-generic-parameters | |||
| error: #[pyclass] cannot have generic parameters. For an explanation, see https://pyo3.rs/v0.23.0-dev/class.html#no-generic-parameters | |||
There was a problem hiding this comment.
Will we need to update this every release? Or will this just become v0.23.0 when that's released and then not change again?
There was a problem hiding this comment.
I think we'll need to update this every release, which is a touch annoying but not the end of the world. I'm prepared to just add it to the usual release prep PR ceremony 😊
davidhewitt
added a commit
that referenced
this pull request
Jul 10, 2024
* use versioned links from docs to guide * use standard python version in `guide-build` ci job
davidhewitt
added a commit
that referenced
this pull request
Jul 16, 2024
* use versioned links from docs to guide * use standard python version in `guide-build` ci job
davidhewitt
added a commit
that referenced
this pull request
Jul 17, 2024
* use versioned links from docs to guide * use standard python version in `guide-build` ci job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes links in docs to use
env!("CARGO_PKG_VERSION")to fill in the current PyO3 version instead of just pointing at https://pyo3.rs/latest.I think this is a nice UX change for users looking at older versions, who will be able to use stable links that might otherwise break when we make adjustments to the guide.