-
Notifications
You must be signed in to change notification settings - Fork 694
Feature/string canonicalization #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/string canonicalization #979
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/string-parsing #979 +/- ##
==========================================================
+ Coverage 75.20% 75.24% +0.04%
==========================================================
Files 434 434
Lines 17513 17539 +26
==========================================================
+ Hits 13170 13197 +27
+ Misses 4343 4342 -1
Continue to review full report at Codecov.
|
|
Which Pest file? |
|
@acoglio we only have one pest file - input/src/leo-input.pest. |
|
That narrows it down 😀 Perhaps you need to make this rule otherwise the implicit |
|
@acoglio good catch that fixed the issue! |
collinc97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
acoglio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
@acoglio We can merge this in since it's just going to another branch, and the Clippy failure exists there as well! We won't check it off the list on the string epic till it's fully merged into master. |
Closes #945.
Eventually, strings should use "..." instead of
.... Similarly, in the inputs, it should use "..." instead of a ['a'...'b']. But, these changes can be done in feature/string-parsing once inputs are merged in, and we refactor string parsing to use "...".Also found a bug with char input parsing that it cannot parse the space character - ' '. Tried messing with it for a while, but I am kind of stuck on why it won't work. Maybe someone more familiar with pest can take a look?