Merge branch 'AutoFixWarnings' of https://github.com/bergmeister/PSScriptAnalyzer into AutoFixWarnings

Author: bergmeister

Tests/Engine/InvokeScriptAnalyzer.tests.ps1

@@ -475,14 +475,14 @@ Describe "Test -Fix Switch" {
     AfterEach {
         if ($null -ne $initialTestScript)
         {
-            $initialTestScript | Set-Content $directory\TestScriptWithFixableWarnings.ps1 -NoNewline
+            [System.IO.File]::WriteAllText("$($directory)\TestScriptWithFixableWarnings.ps1", $initialTestScript) # Set-Content -NoNewline was only introduced in PS v5 and would therefore not work in CI
         }
     }
 
     It "Fixes warnings" {
         # we expect the script to contain warnings
         $warningsBeforeFix = Invoke-ScriptAnalyzer $directory\TestScriptWithFixableWarnings.ps1
-        $warningsBeforeFix.Count | Should Be 4
+        $warningsBeforeFix.Count | Should Be 5
 
         # fix the warnings and expect that it should not return the fixed warnings
         $warningsWithFixSwitch = Invoke-ScriptAnalyzer $directory\TestScriptWithFixableWarnings.ps1 -Fix

Tests/Engine/LibraryUsage.tests.ps1

@@ -15,7 +15,7 @@ $directory = Split-Path -Parent $MyInvocation.MyCommand.Path
 # wraps the usage of ScriptAnalyzer as a .NET library 
 function Invoke-ScriptAnalyzer {
 	param (
-        [CmdletBinding(DefaultParameterSetName="File")]
+        [CmdletBinding(DefaultParameterSetName="File", SupportsShouldProcess = $true)]
 
 		[parameter(Mandatory = $true, Position = 0, ParameterSetName="File")]
 		[Alias("PSPath")]
@@ -78,7 +78,7 @@ function Invoke-ScriptAnalyzer {
 	);
 
     if ($PSCmdlet.ParameterSetName -eq "File") {
-		$supportsShouldProcessFunc = [Func[string, string, bool]]{ return $Recurse.IsPresent }
+		$supportsShouldProcessFunc = [Func[string, string, bool]]{ return $PSCmdlet.Shouldprocess }
 		if ($Fix.IsPresent)
 		{
 			return $scriptAnalyzer.AnalyzeAndFixPath($Path, $supportsShouldProcessFunc, $Recurse.IsPresent);

Tests/Engine/ModuleHelp.Tests.ps1

@@ -121,7 +121,7 @@ function Get-ParametersDefaultFirst {
 	)
 
 	BEGIN {
-		$Common = 'Debug', 'ErrorAction', 'ErrorVariable', 'InformationAction', 'InformationVariable', 'OutBuffer', 'OutVariable', 'PipelineVariable', 'Verbose', 'WarningAction', 'WarningVariable'
+		$Common = 'Debug', 'ErrorAction', 'ErrorVariable', 'InformationAction', 'InformationVariable', 'OutBuffer', 'OutVariable', 'PipelineVariable', 'Verbose', 'WarningAction', 'WarningVariable', 'WhatIf', 'Confirm'
 		$parameters = @()
 	}
 	PROCESS {
@@ -266,7 +266,7 @@ foreach ($command in $commands) {
 		Context "Test parameter help for $commandName" {
 
 			$Common = 'Debug', 'ErrorAction', 'ErrorVariable', 'InformationAction', 'InformationVariable', 'OutBuffer', 'OutVariable',
-			'PipelineVariable', 'Verbose', 'WarningAction', 'WarningVariable'
+			'PipelineVariable', 'Verbose', 'WarningAction', 'WarningVariable', 'WhatIf', 'Confirm'
 
 			# Get parameters. When >1 parameter with same name,
 			# get parameter from the default parameter set, if any.
@@ -315,4 +315,4 @@ foreach ($command in $commands) {
 			}
 		}
 	}
-}
+}

Tests/Engine/TestScriptWithFixableWarnings.ps1

@@ -1,5 +1,5 @@
-# Produce PSAvoidUsingCmdletAliases warning that should get fixed by replacing it with the actual command
+# Produce PSAvoidUsingCmdletAliases and PSAvoidTrailingWhitespace warnings that should get fixed by replacing it with the actual command
 gci . | % { } | ? { } 
 
 # Produces PSAvoidUsingPlainTextForPassword warning that should get fixed by making it a [SecureString]
-function Test-bar([string]$PasswordInPlainText){}
+function Test-bar([string]$PasswordInPlainText){}

Tests/Engine/TestScriptWithFixableWarnings_AfterFix.ps1

@@ -1,5 +1,5 @@
-# Produce PSAvoidUsingCmdletAliases warning that should get fixed by replacing it with the actual command
-Get-ChildItem . | ForEach-Object { } | Where-Object { } 
+# Produce PSAvoidUsingCmdletAliases and PSAvoidTrailingWhitespace warnings that should get fixed by replacing it with the actual command
+Get-ChildItem . | ForEach-Object { } | Where-Object { }
 
 # Produces PSAvoidUsingPlainTextForPassword warning that should get fixed by making it a [SecureString]
-function Test-bar([SecureString]$PasswordInPlainText){}
+function Test-bar([SecureString]$PasswordInPlainText){}