Fix rounding off errors (#467)

maxsam4 · adamdossa · commit 06ce33215c3e · 2018-12-14T10:19:42.000Z
* Fixed rounding off errors

* Increased tolerance

* Reduced tolerance to zero

* Comment updated

* Tolerance set to 2
diff --git a/contracts/modules/STO/USDTieredSTO.sol b/contracts/modules/STO/USDTieredSTO.sol
@@ -455,7 +455,7 @@ contract USDTieredSTO is USDTieredSTOStorage, ISTO, ReentrancyGuard {
             fundsRaisedUSD = fundsRaisedUSD.add(spentUSD);
         }
 
-        spentValue = DecimalMath.mul(DecimalMath.div(spentUSD, originalUSD), _investmentValue);
+        spentValue = DecimalMath.div(spentUSD, _rate);
     }
 
     /**
@@ -494,7 +494,7 @@ contract USDTieredSTO is USDTieredSTOStorage, ISTO, ReentrancyGuard {
             }
         }
 
-        spentValue = DecimalMath.mul(DecimalMath.div(spentUSD, originalUSD), _investmentValue);
+        spentValue = DecimalMath.div(spentUSD, rate);
     }
 
     function _buyTokensChecks(

Original file line number	Diff line number	Diff line change
`@@ -455,7 +455,7 @@ contract USDTieredSTO is USDTieredSTOStorage, ISTO, ReentrancyGuard {`
`455`	`455`	`fundsRaisedUSD = fundsRaisedUSD.add(spentUSD);`
`456`	`456`	`}`
`457`	`457`
`458`		`- spentValue = DecimalMath.mul(DecimalMath.div(spentUSD, originalUSD), _investmentValue);`
	`458`	`+ spentValue = DecimalMath.div(spentUSD, _rate);`
`459`	`459`	`}`
`460`	`460`
`461`	`461`	`/**`
`@@ -494,7 +494,7 @@ contract USDTieredSTO is USDTieredSTOStorage, ISTO, ReentrancyGuard {`
`494`	`494`	`}`
`495`	`495`	`}`
`496`	`496`
`497`		`- spentValue = DecimalMath.mul(DecimalMath.div(spentUSD, originalUSD), _investmentValue);`
	`497`	`+ spentValue = DecimalMath.div(spentUSD, rate);`
`498`	`498`	`}`
`499`	`499`
`500`	`500`	`function _buyTokensChecks(`