Target must be manually exported to avoid breaking change

AugusteBourgois · AugusteBourgois · commit b739beb7dc93 · 2024-10-04T10:29:49.000+02:00
diff --git a/README.md b/README.md
@@ -63,6 +63,9 @@ target_link_libraries(minimal_node PRIVATE
   rclcpp::rclcpp
   turtlesim_parameters
 )
+
+install(TARGETS minimal_node turtlesim_parameters
+  EXPORT ${PROJECT_NAME}Targets
 ```
 
 **setup.py**
diff --git a/example/CMakeLists.txt b/example/CMakeLists.txt
@@ -66,7 +66,7 @@ install(
   DESTINATION include/generate_parameter_library_example
 )
 
-install(TARGETS minimal_publisher
+install(TARGETS minimal_publisher admittance_controller_parameters
   EXPORT export_generate_parameter_library_example
   ARCHIVE DESTINATION lib
   LIBRARY DESTINATION lib
diff --git a/generate_parameter_library/cmake/generate_parameter_library.cmake b/generate_parameter_library/cmake/generate_parameter_library.cmake
@@ -99,8 +99,6 @@ Use #include <${PROJECT_NAME}/${LIB_NAME}.hpp> instead.\")" >> ${LOCAL_PARAM_HEA
     tl_expected::tl_expected
   )
   install(DIRECTORY ${LIB_INCLUDE_DIR} DESTINATION include)
-  install(TARGETS ${LIB_NAME} EXPORT ${PROJECT_NAME}Targets)
-  ament_export_targets(${PROJECT_NAME}Targets HAS_LIBRARY_TARGET)
   ament_export_dependencies(fmt parameter_traits rclcpp rclcpp_lifecycle rsl tcb_span tl_expected)
 endmacro()
 

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,9 @@ target_link_libraries(minimal_node PRIVATE`
`63`	`63`	`rclcpp::rclcpp`
`64`	`64`	`turtlesim_parameters`
`65`	`65`	`)`
	`66`	`+`
	`67`	`+install(TARGETS minimal_node turtlesim_parameters`
	`68`	`+ EXPORT ${PROJECT_NAME}Targets`
`66`	`69`	```
`67`	`70`
`68`	`71`	`setup.py`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ install(`
`66`	`66`	`DESTINATION include/generate_parameter_library_example`
`67`	`67`	`)`
`68`	`68`
`69`		`-install(TARGETS minimal_publisher`
	`69`	`+install(TARGETS minimal_publisher admittance_controller_parameters`
`70`	`70`	`EXPORT export_generate_parameter_library_example`
`71`	`71`	`ARCHIVE DESTINATION lib`
`72`	`72`	`LIBRARY DESTINATION lib`
Original file line number	Diff line number	Diff line change
`@@ -99,8 +99,6 @@ Use #include <${PROJECT_NAME}/${LIB_NAME}.hpp> instead.\")" >> ${LOCAL_PARAM_HEA`
`99`	`99`	`tl_expected::tl_expected`
`100`	`100`	`)`
`101`	`101`	`install(DIRECTORY ${LIB_INCLUDE_DIR} DESTINATION include)`
`102`		`- install(TARGETS ${LIB_NAME} EXPORT ${PROJECT_NAME}Targets)`
`103`		`- ament_export_targets(${PROJECT_NAME}Targets HAS_LIBRARY_TARGET)`
`104`	`102`	`ament_export_dependencies(fmt parameter_traits rclcpp rclcpp_lifecycle rsl tcb_span tl_expected)`
`105`	`103`	`endmacro()`
`106`	`104`