maint: Remove IE related code paths.

Author: thet

src/core/store.test.js

@@ -9,23 +9,13 @@ describe("Core / store", function () {
         it("localStorage accessor", function () {
             var storage = store.local("mypattern");
             expect(storage.prefix).toBe("mypattern");
-            try {
-                expect(storage.backend).toBe(window.localStorage);
-            } catch (e) {
-                // IE8 throws an exception if you try to do something as
-                // simple as window.localStorage===window.localStorage
-            }
+            expect(storage.backend).toBe(window.localStorage);
         });
 
         it("sessionStorage accessor", function () {
             var storage = store.session("mypattern");
             expect(storage.prefix).toBe("mypattern");
-            try {
-                expect(storage.backend).toBe(window.sessionStorage);
-            } catch (e) {
-                // IE8 throws an exception if you try to do something as
-                // simple as window.localStorage===window.localStorage
-            }
+            expect(storage.backend).toBe(window.sessionStorage);
         });
     });
 

src/core/utils.js

@@ -5,19 +5,6 @@ const _MS_PER_DAY = 1000 * 60 * 60 * 24; // Milliseconds per day.
 
 $.fn.safeClone = function () {
     var $clone = this.clone();
-    // IE 9-11 BUG : Placeholder text becomes actual value after deep clone on textarea
-    // https://connect.microsoft.com/IE/feedback/details/781612/placeholder-text-becomes-actual-value-after-deep-clone-on-textarea
-    // Ref:
-    //     https://github.com/Patternslib/Patterns/issues/412
-    //     https://github.com/Patternslib/Patterns/pull/410
-    if (window.document.documentMode) {
-        $clone.findInclusive(":input[placeholder]").each(function (i, item) {
-            var $item = $(item);
-            if ($item.attr("placeholder") === $item.val()) {
-                $item.val("");
-            }
-        });
-    }
     return $clone;
 };
 

src/lib/input-change-events.js

@@ -57,28 +57,10 @@ var _ = {
             }
         }
         if (isText || isNumber) {
-            if ("oninput" in window) {
-                $el.on("input." + namespace, function () {
-                    log.debug("translating input");
-                    $el.trigger("input-change");
-                });
-            } else {
-                // this is the legacy code path for IE8
-                // Work around buggy placeholder polyfill.
-                if ($el.attr("placeholder")) {
-                    $el.on("keyup." + namespace, function () {
-                        log.debug("translating keyup");
-                        $el.trigger("input-change");
-                    });
-                } else {
-                    $el.on("propertychange." + namespace, function (ev) {
-                        if (ev.originalEvent.propertyName === "value") {
-                            log.debug("translating propertychange");
-                            $el.trigger("input-change");
-                        }
-                    });
-                }
-            }
+            $el.on("input." + namespace, function () {
+                log.debug("translating input");
+                $el.trigger("input-change");
+            });
         } else {
             $el.on("change." + namespace, function () {
                 log.debug("translating change");

src/pat/ajax/ajax.test.js

@@ -27,10 +27,6 @@ describe("pat-ajax", function () {
         });
     });
 
-    //
-    // ATTENTION: These might fail on IE8 due to different code
-    // path in jquery.form that does not use $.ajax
-    //
     describe("form", function () {
         var $form, $button, spy_ajax;
 

src/pat/auto-suggest/_auto-suggest.scss

@@ -11,7 +11,6 @@ Version: 3.4.3 Timestamp: Tue Sep 17 06:47:14 PDT 2013
     margin: 0;
     position: relative;
     display: inline-block;
-    /* inline-block for ie7 */
     zoom: 1;
     *display: inline;
     vertical-align: middle;
@@ -421,9 +420,6 @@ disabled look for disabled choices in the results dropdown
 }
 
 .select2-container-multi {
-    .select2-choices {
-        /*min-height: 26px;*/
-    }
     &.select2-container-active .select2-choices {
         border: 1px solid #5897fb;
         outline: none;
@@ -440,7 +436,6 @@ disabled look for disabled choices in the results dropdown
             padding: 0 0 0 0.5em;
             white-space: nowrap;
             height: 1.6em;
-            /*The following line is a patch to make IE8 show the actual input field that's within this LI element*/
             min-width: 200px;
             input {
                 padding: 0;

src/pat/inject/inject.js

@@ -416,25 +416,6 @@ const inject = {
         return $target;
     },
 
-    stopBubblingFromRemovedElement($el, cfgs, ev) {
-        /* IE8 fix. Stop event from propagating IF $el will be removed
-         * from the DOM. With pat-inject, often $el is the target that
-         * will itself be replaced with injected content.
-         *
-         * IE8 cannot handle events bubbling up from an element removed
-         * from the DOM.
-         *
-         * See: http://stackoverflow.com/questions/7114368/why-is-jquery-remove-throwing-attr-exception-in-ie8
-         */
-        for (const cfg of cfgs) {
-            const sel = cfg.target;
-            if ($el.parents(sel).addBack(sel) && !ev.isPropagationStopped()) {
-                ev.stopPropagation();
-                return;
-            }
-        }
-    },
-
     _performInjection(target, $el, $source, cfg, trigger, title) {
         /* Called after the XHR has succeeded and we have a new $source
          * element to inject.
@@ -443,13 +424,7 @@ const inject = {
             $source = $source.contents();
         }
         let $src;
-        // $source.clone() does not work with shived elements in IE8
-        if (document.all && document.querySelector && !document.addEventListener) {
-            $src = $source.map((idx, el) => $(el.outerHTML)[0]);
-        } else {
-            $src = $source.safeClone();
-        }
-
+        $src = $source.safeClone();
         $src.findInclusive("img").on("load", (e) => {
             $(e.currentTarget).trigger("pat-inject-content-loaded");
         });
@@ -491,7 +466,6 @@ const inject = {
          */
         $injected
             .filter((idx, el_) => {
-                // setting data on textnode fails in IE8
                 return el_.nodeType !== TEXT_NODE;
             })
             .data("pat-injected", { origin: cfg.url });
@@ -591,7 +565,6 @@ const inject = {
         $.each(cfgs[0].hooks || [], (idx, hook) =>
             $el.trigger("pat-inject-hook-" + hook)
         );
-        this.stopBubblingFromRemovedElement($el, cfgs, ev);
         const sources$ = await this.callTypeHandler(cfgs[0].dataType, "sources", $el, [
             cfgs,
             data,
@@ -973,15 +946,6 @@ const inject = {
             }
         }
 
-        // XXX: IE8 changes the order of attributes in html. The following
-        // lines move data-pat-inject-rebase-src to src.
-        $page.find("[data-pat-inject-rebase-src]").each((id, el_) => {
-            const $el = $(el_);
-            $el.attr("src", $el.attr("data-pat-inject-rebase-src")).removeAttr(
-                "data-pat-inject-rebase-src"
-            );
-        });
-
         return $page
             .html()
             .replace(/src="" data-pat-inject-rebase-/g, "")

src/pat/modal/modal.js

@@ -101,10 +101,7 @@ export default Base.extend({
 
         // Restore focus in case the active element was a child of $el and
         // the focus was lost during the wrapping.
-        // Only if we have an activeElement, as IE10/11 can have undefined as activeElement
-        if (document.activeElement) {
-            document.activeElement.focus();
-        }
+        document.activeElement?.focus();
 
         this._init_handlers();
         this.resize();

src/pat/sortable/sortable.js

@@ -49,9 +49,6 @@ export default Base.extend({
     },
 
     addHandles: function () {
-        /* Add handles and make them draggable for HTML5 and IE8/9
-         * it has to be an "a" tag (or img) to make it draggable in IE8/9
-         */
         var $sortables_without_handles = this.$sortables.filter(function () {
             return $(this).find(".sortable-handle").length === 0;
         });