feat(core utils): parseLength: handle unitless lengths as pixels.

Author: thet

src/core/utils.js

@@ -447,7 +447,7 @@ function parseTime(time) {
  * parseLength - Parse a length from a string and return the parsed length in
  * pixels.
 
- * @param {String} length - A length string like `1px` or `25%`.
+ * @param {String} length - A length string like `1px` or `25%`. Lengths without a unit are treated as pixels.
  * @param {Number} reference_length - The reference length to use for percentage lengths.
  *
  * @returns {Number} - A integer which represents the parsed length in pixels.
@@ -486,7 +486,7 @@ function parseLength(length, reference_length = null) {
                 (amount * Math.max(window.innerWidth, window.innerHeight)) / 100
             );
         default:
-            return null;
+            return Math.round(amount);
     }
 }
 

src/core/utils.test.js

@@ -480,6 +480,24 @@ describe("parseLength", function () {
         expect(p).toThrow();
     });
 
+    it("handles unitless lengths", function () {
+        // As strings
+        expect(utils.parseLength("0")).toBe(0);
+        expect(utils.parseLength("1")).toBe(1);
+        expect(utils.parseLength("10")).toBe(10);
+        expect(utils.parseLength("100")).toBe(100);
+        expect(utils.parseLength("1000.1")).toBe(1000);
+        expect(utils.parseLength("1000.9")).toBe(1001);
+
+        // As numbers
+        expect(utils.parseLength(0)).toBe(0);
+        expect(utils.parseLength(1)).toBe(1);
+        expect(utils.parseLength(10)).toBe(10);
+        expect(utils.parseLength(100)).toBe(100);
+        expect(utils.parseLength(1000.1)).toBe(1000);
+        expect(utils.parseLength(1000.9)).toBe(1001);
+    });
+
     it("handles pixel lengths", function () {
         expect(utils.parseLength("10px")).toBe(10);
         expect(utils.parseLength("100px")).toBe(100);