Skip to content

Commit c4cbb3b

Browse files
committed
maint: Remove core/remove and core/url.
Remove core/remove and core/url and it's usage in pat-slides. core/url can nowadays be replaced by the URL interface from the web API. core/remove did invoke the destroy event to invoke clean-up routines. core/remove result in an infinite recursion error in combination with the TinyMCE API due to core/remove's patching of the internal cleanData jQuery API. pat-slides is currently not in a working state, so the removal is OK. Anyways, this triggers the question how to handle Pattern cleanup in the future. The answer is in a mutation observer on document level, but this will be part of a future release.
1 parent 7dd4c36 commit c4cbb3b

File tree

4 files changed

+3
-150
lines changed

4 files changed

+3
-150
lines changed

src/core/remove.js

Lines changed: 0 additions & 14 deletions
This file was deleted.

src/core/url.js

Lines changed: 0 additions & 63 deletions
This file was deleted.

src/core/url.test.js

Lines changed: 0 additions & 68 deletions
This file was deleted.

src/pat/slides/slides.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
import $ from "jquery";
77
import registry from "../../core/registry";
88
import utils from "../../core/utils";
9-
import url from "../../core/url";
10-
import "../../core/remove";
119

1210
var slides = {
1311
name: "slides",
@@ -24,9 +22,9 @@ var slides = {
2422
}
2523
await import("slides/src/slides"); // loads ``Presentation`` globally.
2624

27-
var parameters = url.parameters();
28-
if (parameters.slides !== undefined) {
29-
var requested_ids = slides._collapse_ids(parameters.slides);
25+
const parameters = new URL(window.location.href).searchParams;
26+
if (parameters.get("slides") !== null) {
27+
var requested_ids = slides._collapse_ids(parameters.get("slides"));
3028
if (requested_ids) slides._remove_slides($el, requested_ids);
3129
}
3230
$el.each(function () {

0 commit comments

Comments
 (0)