Skip to content

Try Php 8 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 12, 2020
Merged

Try Php 8 #28

merged 5 commits into from
Dec 12, 2020

Conversation

@VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Dec 11, 2020 •
edited
Loading

Close #26

@VincentLanglet VincentLanglet marked this pull request as ready for review December 11, 2020 23:42
@coveralls
Copy link

coveralls commented Dec 12, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 55.0% when pulling a082da2 on VincentLanglet:php8 into fd16b34 on Orbitale:main.

@VincentLanglet
Copy link
Contributor Author

VincentLanglet commented Dec 12, 2020

@Pierstoval The PR seems ready to merge with php 8 compatibility.

@Pierstoval
Copy link
Member

Pierstoval commented Dec 12, 2020

Is there no way to keep PHP 7.1 compatibility?

@VincentLanglet
Copy link
Contributor Author

VincentLanglet commented Dec 12, 2020

Is there no way to keep PHP 7.1 compatibility?

Didn't try, you were not 7.1-compatible.
https://github.com/Orbitale/ImageMagickPHP/blob/main/composer.json#L16

I just updated the readme.

@Pierstoval
Copy link
Member

Pierstoval commented Dec 12, 2020

Indeed, good catch 😉

@Pierstoval Pierstoval merged commit 03d55ec into Orbitale:main Dec 12, 2020
@Pierstoval
Copy link
Member

Pierstoval commented Dec 12, 2020

Thanks @VincentLanglet 👍

@VincentLanglet
Copy link
Contributor Author

VincentLanglet commented Dec 12, 2020

You're welcome !

Do you mind creating a new release with this official support of php 8 ?

@VincentLanglet VincentLanglet deleted the php8 branch December 12, 2020 20:07
@Pierstoval
Copy link
Member

Pierstoval commented Dec 13, 2020

Will do :)

@Pierstoval
Copy link
Member

Pierstoval commented Dec 13, 2020

Done in v3.0.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pierstoval Pierstoval Pierstoval approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compatibility with PHP 8

3 participants

@VincentLanglet @coveralls @Pierstoval