Skip to content

Commit b5a7f97

Browse files
Amxxernestognwvittominacori
authored
Improve ERC-1363 documentation (#4854)
Co-authored-by: Ernesto García <[email protected]> Co-authored-by: Vittorio Minacori <[email protected]>
1 parent 6b30d2d commit b5a7f97

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

contracts/token/ERC20/extensions/ERC1363.sol

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ abstract contract ERC1363 is ERC20, ERC165, IERC1363 {
5858
*
5959
* - The target has code (i.e. is a contract).
6060
* - The target `to` must implement the {IERC1363Receiver} interface.
61-
* - The target should return the {IERC1363Receiver} interface id.
61+
* - The target must return the {IERC1363Receiver-onTransferReceived} selector to accept the transfer.
6262
* - The internal {transfer} must succeed (returned `true`).
6363
*/
6464
function transferAndCall(address to, uint256 value) public returns (bool) {
@@ -85,7 +85,7 @@ abstract contract ERC1363 is ERC20, ERC165, IERC1363 {
8585
*
8686
* - The target has code (i.e. is a contract).
8787
* - The target `to` must implement the {IERC1363Receiver} interface.
88-
* - The target should return the {IERC1363Receiver} interface id.
88+
* - The target must return the {IERC1363Receiver-onTransferReceived} selector to accept the transfer.
8989
* - The internal {transferFrom} must succeed (returned `true`).
9090
*/
9191
function transferFromAndCall(address from, address to, uint256 value) public returns (bool) {
@@ -116,8 +116,8 @@ abstract contract ERC1363 is ERC20, ERC165, IERC1363 {
116116
* Requirements:
117117
*
118118
* - The target has code (i.e. is a contract).
119-
* - The target `to` must implement the {IERC1363Spender} interface.
120-
* - The target should return the {IERC1363Spender} interface id.
119+
* - The target `spender` must implement the {IERC1363Spender} interface.
120+
* - The target must return the {IERC1363Spender-onApprovalReceived} selector to accept the approval.
121121
* - The internal {approve} must succeed (returned `true`).
122122
*/
123123
function approveAndCall(address spender, uint256 value) public returns (bool) {
@@ -143,7 +143,7 @@ abstract contract ERC1363 is ERC20, ERC165, IERC1363 {
143143
*
144144
* - The target has code (i.e. is a contract).
145145
* - The target `to` must implement the {IERC1363Receiver} interface.
146-
* - The target should return the {IERC1363Receiver} interface id.
146+
* - The target must return the {IERC1363Receiver-onTransferReceived} selector to accept the transfer.
147147
*/
148148
function _checkOnTransferReceived(address from, address to, uint256 value, bytes memory data) private {
149149
if (to.code.length == 0) {
@@ -172,8 +172,8 @@ abstract contract ERC1363 is ERC20, ERC165, IERC1363 {
172172
* Requirements:
173173
*
174174
* - The target has code (i.e. is a contract).
175-
* - The target `to` must implement the {IERC1363Spender} interface.
176-
* - The target should return the {IERC1363Spender} interface id.
175+
* - The target `spender` must implement the {IERC1363Spender} interface.
176+
* - The target must return the {IERC1363Spender-onApprovalReceived} selector to accept the approval.
177177
*/
178178
function _checkOnApprovalReceived(address spender, uint256 value, bytes memory data) private {
179179
if (spender.code.length == 0) {

0 commit comments

Comments
 (0)