Remove duplicated SLOAD in Arrays.findUpperBound (#4442)

Co-authored-by: Hadrien Croubois <[email protected]>
Co-authored-by: Francisco Giordano <[email protected]>

Author: 3 people

.changeset/fluffy-countries-buy.md

@@ -0,0 +1,5 @@
+---
+'openzeppelin-solidity': minor
+---
+
+`Arrays`: Optimize `findUpperBound` by removing redundant SLOAD.

contracts/utils/Arrays.sol

@@ -22,13 +22,13 @@ library Arrays {
      * repeated elements.
      */
     function findUpperBound(uint256[] storage array, uint256 element) internal view returns (uint256) {
-        if (array.length == 0) {
-            return 0;
-        }
-
         uint256 low = 0;
         uint256 high = array.length;
 
+        if (high == 0) {
+            return 0;
+        }
+
         while (low < high) {
             uint256 mid = Math.average(low, high);