Skip to content

Commit e33703f

Browse files
committed
Remove finalizer
1 parent 82ca4b9 commit e33703f

File tree

2 files changed

+8
-14
lines changed

2 files changed

+8
-14
lines changed

content/modules/ROOT/examples/applicationsets/coolstore-list-appset.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ kind: ApplicationSet
33
metadata:
44
name: coolstore
55
namespace: $USER-argocd
6-
finalizers:
7-
- resources-finalizer.argocd.argoproj.io/foreground
86
spec:
97
goTemplate: true
108
goTemplateOptions: ["missingkey=error"]

content/modules/ROOT/pages/04-applicationsets.adoc

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -160,21 +160,19 @@ kind: ApplicationSet
160160
metadata:
161161
name: coolstore-apps
162162
namespace: {user}-argocd
163-
finalizers:
164-
- resources-finalizer.argocd.argoproj.io <1>
165163
spec:
166164
generators:
167-
- list: <2>
165+
- list: <1>
168166
elements:
169-
- environment: dev <3>
167+
- environment: dev <2>
170168
- environment: stage
171169
- environment: prod
172170
goTemplate: true
173171
goTemplateOptions:
174172
- missingkey=error
175-
template: <4>
173+
template: <3>
176174
metadata:
177-
name: coolstore-{{.environment}} <5>
175+
name: coolstore-{{.environment}} <4>
178176
namespace: {user}-argocd
179177
spec:
180178
destination:
@@ -190,13 +188,11 @@ spec:
190188
prune: true
191189
selfHeal: true
192190
----
193-
<1> Argo CD will automatically delete the Applications when the ApplicationSet is deleted. Including a finalizer ensures that the
194-
resources the Application deployed will also be deleted. See more information link:https://argo-cd.readthedocs.io/en/stable/user-guide/app_deletion/#about-the-deletion-finalizer[here,window="_blank"].
195-
<2> We are using the `list` generator which enables us to provide a static list of elements to dynamically
191+
<1> We are using the `list` generator which enables us to provide a static list of elements to dynamically
196192
generate applications, basically it is 1:1 per element
197-
<3> Each element has one value, `environment`, which will be templated into the resulting Application object.
198-
<4> The `template` section is where we define the Application resource that the ApplicationSet will create
199-
<5> Here is an example of referencing the `environment` value to template the name.
193+
<2> Each element has one value, `environment`, which will be templated into the resulting Application object.
194+
<3> The `template` section is where we define the Application resource that the ApplicationSet will create
195+
<4> Here is an example of referencing the `environment` value to template the name.
200196

201197
Confirm the three Applications, one for each environment, were created:
202198

0 commit comments

Comments
 (0)