Chore: remove redundant formatting in web3 remote signer config #15985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
That was added because the web3signer version for some reason required it, MaxBlobs Per Block Electra is not a supported config anymore and there is no redundancy |
Author
I still think this tweak helps. Dropping the nested fmt.Sprintf keeps the YAML identical while trimming an extra allocation, so the change is useful. |
Contributor
|
ideally we just remove the whole thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the nested fmt.Sprintf when writing MAX_BLOBS_PER_BLOCK_ELECTRA keep identical YAML output with one allocation instead of two