Modified the ServerTaskWaiter implementation #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenicsim1
approved these changes
Jan 17, 2023
| if (pollingCallback) { | ||
| const taskDetails = await spaceServerTaskRepository.getDetails(serverTaskId); | ||
| pollingCallback(taskDetails); | ||
| const tasks = await spaceServerTaskRepository.getByIds(serverTaskIds); |
There was a problem hiding this comment.
We should only kick this off if serverTaskIds length is > 0. Should not matter too much from the way getByIds is implemented but as a safety check as no task ids means all for server
There was a problem hiding this comment.
Good pickup, I'd forgotten about that bit. I've added an early exit at the top of the method to prevent the first call possibly having 0 ids. The if at the bottom of the loop will set stop to true and therefore already prevent it from happening on subsequent calls.
…r will return every task in the first call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation was based on older logic, from the C# CLI and portal behaviours. It was very chatting and potentially quite inefficient though. This PR modifies the external contract for it just slightly and re-implements the internal behaviour to use less API calls.