Allow overriding the keyed hashing router #799
+32
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to implement a custom router (similar to what we did for the scalar router). This updates the RouterFactory interface to include a function for getting a keyedRouter (i.e. `Router<KeyValuePair<K, V>>`) It's backwards compatible and should not break any usages.
timmartin-stripe
requested review from
Andyz26,
calvin681,
dtrager02,
fdc-ntflx,
hellolittlej and
james-lubin
as code owners
timmartin-stripe
requested a deployment
to
Integrate Pull Request
GitHub Actions
Waiting
Andyz26
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to implement a custom router (similar to what we did for the scalar router). This updates the RouterFactory interface to include a function for getting a keyedRouter (i.e.
Router<KeyValuePair<K, V>>) It's backwards compatible and should not break any usages.Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests