fix(deps): update chokidar, so we can watch dirs with (
#4133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chokidar 1.7.0, which we are currently using, is unable to watch directories with names that contain glob symbols (like `(`, `*`, etc.). There are two ways to fix this: - pass `disableGlobbing: true`, so all paths will be treated as strings. - update chokidar to latest version, where the issue is fixed Suggested solution is to update chokidar to latest version, so we'll get all other fixes listed [here](https://github.com/paulmillr/chokidar/blob/master/CHANGELOG.md)
Fatme
approved these changes
Nov 14, 2018
Contributor
Author
|
run ci |
DimitarTachev
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chokidar 1.7.0, which we are currently using, is unable to watch directories with names that contain glob symbols (like
(,*, etc.). There are two ways to fix this:disableGlobbing: true, so all paths will be treated as strings.Suggested solution is to update chokidar to latest version, so we'll get all other fixes listed here
PR Checklist
What is the current behavior?
Unable to LiveSync changes from project which has
(in the dir name.What is the new behavior?
LiveSync works for projects which have
(in the dir name.Fixes/Implements/Closes #4129