feat(create-project): allow --force to forcefully create git repo inside another one

Author: rigor789

lib/services/project-service.ts

@@ -114,10 +114,12 @@ export class ProjectService implements IProjectService {
 		// sub projects in an existing git repo.
 		if (this.$options.git) {
 			try {
-				const git: SimpleGit = simpleGit(projectDir);
-				if (await git.checkIsRepo()) {
-					// throwing here since we're catching below.
-					throw new Error("Already part of a git repository.");
+				if (!this.$options.force) {
+					const git: SimpleGit = simpleGit(projectDir);
+					if (await git.checkIsRepo()) {
+						// throwing here since we're catching below.
+						throw new Error("Already part of a git repository.");
+					}
 				}
 				await this.$childProcess.exec(`git init ${projectDir}`);
 				await this.$childProcess.exec(`git -C ${projectDir} add --all`);

test/project-service.ts

@@ -10,7 +10,7 @@ import {
 	IProjectDataService,
 	IProjectService,
 } from "../lib/definitions/project";
-import { IProjectNameService } from "../lib/declarations";
+import { IOptions, IProjectNameService } from "../lib/declarations";
 import { IInjector } from "../lib/common/definitions/yok";
 import { IDictionary, IFileSystem } from "../lib/common/declarations";
 import { ProjectConfigService } from "../lib/services/project-config-service";
@@ -118,6 +118,26 @@ describe("projectService", () => {
 				projectName,
 				projectDir,
 			});
+		});
+
+		it("creates a git repo", async () => {
+			const projectName = invalidProjectName;
+			const testInjector = getTestInjector({ projectName });
+			const options = testInjector.resolve<IOptions>("options");
+			const projectService = testInjector.resolve<IProjectService>(
+				ProjectServiceLib.ProjectService
+			);
+			const projectDir = path.join(dirToCreateProject, projectName);
+
+			// force creation to skip git repo check...
+			options.force = true;
+
+			await projectService.createProject({
+				projectName: projectName,
+				pathToProject: dirToCreateProject,
+				force: true,
+				template: constants.RESERVED_TEMPLATE_NAMES["default"],
+			});
 
 			assert.deepEqual(
 				testInjector.resolve("childProcess")._getExecutedCommands(),
@@ -129,6 +149,30 @@ describe("projectService", () => {
 			);
 		});
 
+		it("does not create a git repo with --no-git", async () => {
+			const projectName = invalidProjectName;
+			const testInjector = getTestInjector({ projectName });
+			const options = testInjector.resolve<IOptions>("options");
+			const projectService = testInjector.resolve<IProjectService>(
+				ProjectServiceLib.ProjectService
+			);
+
+			// simulate --no-git
+			options.git = false;
+
+			await projectService.createProject({
+				projectName: projectName,
+				pathToProject: dirToCreateProject,
+				force: true,
+				template: constants.RESERVED_TEMPLATE_NAMES["default"],
+			});
+
+			assert.deepEqual(
+				testInjector.resolve("childProcess")._getExecutedCommands(),
+				[]
+			);
+		});
+
 		it("fails when invalid name is passed when projectNameService fails", async () => {
 			const projectName = invalidProjectName;
 			const testInjector = getTestInjector({ projectName });