Add module condition, so webpack loads es6 module version
#129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even when handling the `exports` table, as done in `webpack` 5. `webpack` 5, at least at present, doesn't handle esm/cjs interop the same way as `node`, so we can;t use the same source as in `node`.
|
Confirmed that this fixes the issue in the repro from webpack/webpack#11613 (comment) Both: and Work. Gonna look into why this wasn't the case in #131 |
|
Alright, I've swapped to |
weswigham
changed the title
webpack condition, so webpack loads es6 module versionmodule condition, so webpack loads es6 module version
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when handling the
exportstable, as done inwebpack5.webpack5, at least at present per this thread, doesn't handle esm/cjs interop the same way asnode, so we can't use the same source as innode.This should hopefully cause
webpackto uniformly prioritize the es module sources, as it did because of themoduleentrypoint before we addedexports.@orta you mentioned having a webpack 5 test - care to add it to this PR?