Skip to content

Commit f8b78d5

Browse files
committed
Apply ts-expect-error to flaky immer type errors
1 parent c19b225 commit f8b78d5

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

packages/accounts-controller/src/AccountsController.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -444,8 +444,7 @@ export class AccountsController extends BaseController<
444444
metadata: { ...account.metadata, ...metadata },
445445
};
446446
// Do not remove this comment - This error is flaky: Comment out or restore the `ts-expect-error` directive below as needed.
447-
// See: https://github.com/MetaMask/utils/issues/168
448-
// // @ts-expect-error Known issue - `Json` causes recursive error in immer `Draft`/`WritableDraft` types
447+
// // @ts-expect-error - Known issue: `Json` causes recursive error in immer `Draft`/`WritableDraft` types (See: https://github.com/MetaMask/utils/issues/168)
449448
currentState.internalAccounts.accounts[accountId] = internalAccount;
450449
});
451450
}

packages/permission-controller/src/PermissionController.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1369,6 +1369,8 @@ export class PermissionController<
13691369
);
13701370

13711371
if (caveatIndex === -1) {
1372+
// Do not remove this comment - This error is flaky: Comment out or restore the `ts-expect-error` directive below as needed.
1373+
// // @ts-expect-error - Known issue: `Json` causes recursive error in immer `Draft`/`WritableDraft` types (See: https://github.com/MetaMask/utils/issues/168)
13721374
permission.caveats.push(caveat);
13731375
} else {
13741376
permission.caveats.splice(caveatIndex, 1, caveat);

packages/permission-controller/src/SubjectMetadataController.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,8 @@ export class SubjectMetadataController extends BaseController<
235235
*/
236236
trimMetadataState(): void {
237237
this.update((draftState) => {
238-
// @ts-expect-error ts(2589)
238+
// Do not remove this comment - This error is flaky: Comment out or restore the `ts-expect-error` directive below as needed.
239+
// @ts-expect-error - Known issue: `Json` causes recursive error in immer `Draft`/`WritableDraft` types (See: https://github.com/MetaMask/utils/issues/168)
239240
return SubjectMetadataController.getTrimmedState(
240241
draftState,
241242
this.subjectHasPermissions,

0 commit comments

Comments
 (0)