refactor(common): remove unused code and migrate to provideHttpClient

Replaces deprecated `HttpClientModule` with `provideHttpClient` and cleans up
unused code

Apply suggestion from @JeanMeche

Co-authored-by: Matthieu Riegler <[email protected]>

Author: MeAkib

packages/common/http/src/backend.ts

@@ -12,12 +12,10 @@ import {HttpRequest} from './request';
 import {HttpEvent} from './response';
 import {FetchBackend} from './fetch';
 import {HttpXhrBackend} from './xhr';
-import {isPlatformServer} from '@angular/common';
 import {
   EnvironmentInjector,
   inject,
   Injectable,
-  PLATFORM_ID,
   ɵConsole as Console,
   ɵformatRuntimeError as formatRuntimeError,
   PendingTasks,

packages/common/http/test/module_spec.ts

@@ -13,12 +13,12 @@ import {HTTP_INTERCEPTORS, HttpInterceptor} from '../src/interceptor';
 import {HttpRequest} from '../src/request';
 import {HttpEvent, HttpResponse} from '../src/response';
 import {HttpTestingController} from '../testing/src/api';
-import {HttpClientTestingModule} from '../testing/src/module';
 import {TestRequest} from '../testing/src/request';
 import {Injectable, Injector} from '@angular/core';
 import {TestBed} from '@angular/core/testing';
 import {Observable} from 'rxjs';
 import {map} from 'rxjs/operators';
+import {provideHttpClientTesting} from '../testing/src/provider';
 
 const IS_INTERCEPTOR_C_ENABLED = new HttpContextToken<boolean | undefined>(() => undefined);
 
@@ -80,11 +80,12 @@ describe('HttpClientModule', () => {
   let injector: Injector;
   beforeEach(() => {
     TestBed.configureTestingModule({
-      imports: [HttpClientTestingModule],
+      imports: [],
       providers: [
         {provide: HTTP_INTERCEPTORS, useClass: InterceptorA, multi: true},
         {provide: HTTP_INTERCEPTORS, useClass: InterceptorB, multi: true},
         {provide: HTTP_INTERCEPTORS, useClass: InterceptorC, multi: true},
+        provideHttpClientTesting(),
       ],
     });
     injector = TestBed.inject(Injector);
@@ -134,8 +135,10 @@ describe('HttpClientModule', () => {
   it('allows interceptors to inject HttpClient', (done) => {
     TestBed.resetTestingModule();
     TestBed.configureTestingModule({
-      imports: [HttpClientTestingModule],
-      providers: [{provide: HTTP_INTERCEPTORS, useClass: ReentrantInterceptor, multi: true}],
+      providers: [
+        {provide: HTTP_INTERCEPTORS, useClass: ReentrantInterceptor, multi: true},
+        provideHttpClientTesting(),
+      ],
     });
     injector = TestBed.inject(Injector);
     injector

packages/common/http/test/provider_spec.ts

@@ -21,7 +21,7 @@ import {
   HttpXhrBackend,
   JsonpClientBackend,
 } from '../index';
-import {HttpClientTestingModule, HttpTestingController, provideHttpClientTesting} from '../testing';
+import {HttpTestingController, provideHttpClientTesting} from '../testing';
 import {
   ApplicationRef,
   createEnvironmentInjector,
@@ -438,8 +438,8 @@ describe('provideHttpClient', () => {
 
         it('should be able to connect to a legacy-provided HttpClient context', () => {
           TestBed.configureTestingModule({
-            imports: [HttpClientTestingModule],
-            providers: [provideLegacyInterceptor('parent')],
+            imports: [],
+            providers: [provideLegacyInterceptor('parent'), provideHttpClientTesting()],
           });
 
           const child = createEnvironmentInjector(

packages/common/http/testing/src/module.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import {HttpClientModule} from '../../index';
+import {provideHttpClient, withInterceptorsFromDi} from '../../index';
 import {NgModule} from '@angular/core';
 
 import {provideHttpClientTesting} from './provider';
@@ -21,7 +21,7 @@ import {provideHttpClientTesting} from './provider';
  * @deprecated Add `provideHttpClientTesting()` to your providers instead.
  */
 @NgModule({
-  imports: [HttpClientModule],
-  providers: [provideHttpClientTesting()],
+  imports: [],
+  providers: [provideHttpClient(withInterceptorsFromDi()), provideHttpClientTesting(), ],
 })
 export class HttpClientTestingModule {}

packages/common/src/directives/ng_template_outlet.ts

@@ -12,7 +12,6 @@ import {
   Injector,
   Input,
   OnChanges,
-  SimpleChange,
   SimpleChanges,
   TemplateRef,
   ViewContainerRef,

packages/common/test/directives/ng_component_outlet_spec.ts

@@ -9,7 +9,6 @@
 import {CommonModule} from '../../index';
 import {NgComponentOutlet} from '../../src/directives/ng_component_outlet';
 import {
-  Compiler,
   Component,
   ComponentRef,
   createEnvironmentInjector,
@@ -19,7 +18,6 @@ import {
   Injector,
   Input,
   NgModule,
-  NgModuleFactory,
   NO_ERRORS_SCHEMA,
   Optional,
   QueryList,

packages/router/src/operators/check_guards.ts

@@ -25,9 +25,9 @@ import {
   CanActivateFn,
   CanDeactivateFn,
   GuardResult,
-  CanLoadFn,
   CanMatchFn,
   Route,
+  CanLoadFn,
 } from '../models';
 import {redirectingNavigationError} from '../navigation_canceling_error';
 import type {NavigationTransition} from '../navigation_transition';

packages/router/src/utils/type_guards.ts

@@ -9,12 +9,6 @@
 import {EmptyError} from 'rxjs';
 
 import {CanActivateChildFn, CanActivateFn, CanDeactivateFn, CanLoadFn, CanMatchFn} from '../models';
-import {
-  NAVIGATION_CANCELING_ERROR,
-  NavigationCancelingError,
-  RedirectingNavigationCancelingError,
-} from '../navigation_canceling_error';
-import {isUrlTree} from '../url_tree';
 
 /**
  * Simple function check, but generic so type inference will flow. Example: