Skip to content

Commit 6eabe58

Browse files
Merge pull request #9989 from minosgalanakis/issue9887_add_basic_defragmentation_tests
Add basic handshake defragmentation tests in ssl-opt
2 parents 28f8e20 + 4354dc6 commit 6eabe58

File tree

3 files changed

+544
-0
lines changed

3 files changed

+544
-0
lines changed

ChangeLog.d/tls-hs-defrag-in.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,10 @@ Bugfix
33
by the spec. Lack of support was causing handshake failures with some
44
servers, especially with TLS 1.3 in practice (though both protocol
55
version could be affected in principle, and both are fixed now).
6+
The initial fragment for each handshake message must be at least 4 bytes.
7+
8+
Server-side, defragmentation of the ClientHello message is only
9+
supported if the server accepts TLS 1.3 (regardless of whether the
10+
ClientHello is 1.3 or 1.2). That is, servers configured (either
11+
at compile time or at runtime) to only accept TLS 1.2 will
12+
still fail the handshake if the ClientHello message is fragmented.

tests/scripts/analyze_outcomes.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,11 @@ def _has_word_re(words: typing.Iterable[str],
5050
# TLS doesn't use restartable ECDH yet.
5151
# https://github.com/Mbed-TLS/mbedtls/issues/7294
5252
re.compile(r'EC restart:.*no USE_PSA.*'),
53+
# Temporary disable Handshake defragmentation tests until mbedtls
54+
# pr #10011 has been merged.
55+
'Handshake defragmentation on client: len=4, TLS 1.2',
56+
'Handshake defragmentation on client: len=5, TLS 1.2',
57+
'Handshake defragmentation on client: len=13, TLS 1.2'
5358
],
5459
'test_suite_config.mbedtls_boolean': [
5560
# Missing coverage of test configurations.

0 commit comments

Comments
 (0)