Skip to content

Conversation

@geoochi
Copy link
Contributor

@geoochi geoochi commented Sep 29, 2024

Overview: What does this pull request change?

use np.float64 while numpy >= 2.0

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@JasonGrace2282
Copy link
Member

Is there a reason not to use np.float_ in numpy>=2.0?

@geoochi
Copy link
Contributor Author

geoochi commented Oct 4, 2024

reason: https://numpy.org/devdocs/release/2.0.0-notes.html

actually it will raise AttributeError when using np.float_ in numpy>=2.0:

AttributeError: np.float_ was removed in the NumPy 2.0 release. Use np.float64 instead.

Copy link
Member

@JasonGrace2282 JasonGrace2282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, I missed it before. Thanks :)

@behackl behackl merged commit d6f066c into ManimCommunity:main Oct 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants