From e43f98063e150eea6e5ede8021fb4b39a59f209e Mon Sep 17 00:00:00 2001 From: Irvanal Haq Date: Fri, 30 Aug 2024 20:46:11 +0700 Subject: [PATCH 1/2] Simplify Sector Class by Removing Redundant Parameters --- manim/mobject/geometry/arc.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/manim/mobject/geometry/arc.py b/manim/mobject/geometry/arc.py index c5c4e31e59..30e2171c2c 100644 --- a/manim/mobject/geometry/arc.py +++ b/manim/mobject/geometry/arc.py @@ -897,17 +897,15 @@ class Sector(AnnularSector): class ExampleSector(Scene): def construct(self): - sector = Sector(outer_radius=2, inner_radius=1) - sector2 = Sector(outer_radius=2.5, inner_radius=0.8).move_to([-3, 0, 0]) + sector = Sector(radius=2) + sector2 = Sector(radius=2.5, angle=60*DEGREES).move_to([-3, 0, 0]) sector.set_color(RED) sector2.set_color(PINK) self.add(sector, sector2) """ - def __init__( - self, outer_radius: float = 1, inner_radius: float = 0, **kwargs - ) -> None: - super().__init__(inner_radius=inner_radius, outer_radius=outer_radius, **kwargs) + def __init__(self, radius: float = 1, **kwargs) -> None: + super().__init__(inner_radius = 0, outer_radius = radius, **kwargs) class Annulus(Circle): From a092bcc4c1ebea69dc69eb902c82c82c1bd1a509 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 30 Aug 2024 15:14:02 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- manim/mobject/geometry/arc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manim/mobject/geometry/arc.py b/manim/mobject/geometry/arc.py index 30e2171c2c..7c694cb408 100644 --- a/manim/mobject/geometry/arc.py +++ b/manim/mobject/geometry/arc.py @@ -905,7 +905,7 @@ def construct(self): """ def __init__(self, radius: float = 1, **kwargs) -> None: - super().__init__(inner_radius = 0, outer_radius = radius, **kwargs) + super().__init__(inner_radius=0, outer_radius=radius, **kwargs) class Annulus(Circle):