Skip to content

Rewrite Animation Loop #3785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 21, 2024
Merged

Rewrite Animation Loop #3785

merged 7 commits into from
Jun 21, 2024

Conversation

@JasonGrace2282
Copy link
Member

@JasonGrace2282 JasonGrace2282 commented May 29, 2024 •
edited
Loading

Now the RenderManager (renamed to Manager) is in charge of

  • Scene
  • Window
  • Renderer
  • FileWriter (tbd in a future PR)

TODO

  • Figure out why stuff isn't being drawn on the screen
  • Make sure updaters work

#3817

@JasonGrace2282 JasonGrace2282 self-assigned this May 29, 2024
@JasonGrace2282 JasonGrace2282 marked this pull request as ready for review June 21, 2024 15:14
@JasonGrace2282 JasonGrace2282 requested a review from MrDiver June 21, 2024 15:14
@MrDiver MrDiver merged commit 69ddb0e into ManimCommunity:experimental Jun 21, 2024
@JasonGrace2282 JasonGrace2282 deleted the manager branch June 21, 2024 17:00
@JasonGrace2282 JasonGrace2282 mentioned this pull request Jun 23, 2024
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrDiver MrDiver MrDiver approved these changes

Assignees

@JasonGrace2282 JasonGrace2282

Labels

experimental

Projects

Dev Board
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JasonGrace2282 @MrDiver