Skip to content

Commit 8f131f0

Browse files
fixed progress bar
1 parent c76c39a commit 8f131f0

File tree

4 files changed

+12
-21
lines changed

4 files changed

+12
-21
lines changed

manim/__main__.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
import sys
21
import click
3-
from click.testing import CliRunner
42
from click_default_group import DefaultGroup
53
from manim.constants import EPILOG
64
from manim.constants import CONTEXT_SETTINGS
@@ -29,5 +27,4 @@ def main(ctx):
2927
main.add_command(render)
3028

3129
if __name__ == "__main__":
32-
runner = CliRunner()
33-
manim = runner.invoke(main, sys.argv[1:])
30+
main()

manim/_config/default.cfg

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,11 @@ show_in_file_browser = False
4040
verbosity = INFO
4141

4242
# --progress_bar
43-
progress_bar = True
43+
progress_bar = show
4444

4545
# -o, --output_file
4646
output_file =
4747

48-
# --leave_progress_bars
49-
leave_progress_bars = False
50-
5148
# --log_to_file
5249
log_to_file = False
5350

manim/_config/utils.py

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,6 @@ class MyScene(Scene):
263263
"images_dir",
264264
"input_file",
265265
"webgl_renderer_path",
266-
"leave_progress_bars",
267266
"log_dir",
268267
"log_to_file",
269268
"max_files_cached",
@@ -508,9 +507,7 @@ def digest_parser(self, parser: configparser.ConfigParser) -> "ManimConfig":
508507
"save_as_gif",
509508
"preview",
510509
"show_in_file_browser",
511-
"progress_bar",
512510
"sound",
513-
"leave_progress_bars",
514511
"log_to_file",
515512
"disable_caching",
516513
"flush_cache",
@@ -575,6 +572,10 @@ def digest_parser(self, parser: configparser.ConfigParser) -> "ManimConfig":
575572
if val:
576573
setattr(self, "tex_template_file", val)
577574

575+
val = parser["CLI"].get("progress_bar")
576+
if val:
577+
setattr(self, "progress_bar", val)
578+
578579
val = parser["ffmpeg"].get("loglevel")
579580
if val:
580581
setattr(self, "ffmpeg_loglevel", val)
@@ -621,14 +622,14 @@ def digest_args(self, args: argparse.Namespace) -> "ManimConfig":
621622
"preview",
622623
"show_in_file_browser",
623624
"sound",
624-
"leave_progress_bars",
625625
"write_to_movie",
626626
"save_last_frame",
627627
"save_pngs",
628628
"save_as_gif",
629629
"write_all",
630630
"disable_caching",
631631
"flush_cache",
632+
"progress_bar",
632633
"transparent",
633634
"scene_names",
634635
"verbosity",
@@ -756,16 +757,12 @@ def digest_file(self, filename: str) -> "ManimConfig":
756757

757758
progress_bar = property(
758759
lambda self: self._d["progress_bar"],
759-
lambda self, val: self._set_boolean("progress_bar", val),
760+
lambda self, val: self._set_from_list(
761+
"progress_bar", val, ["none", "show", "leave"]
762+
),
760763
doc="Whether to show progress bars while rendering animations.",
761764
)
762765

763-
leave_progress_bars = property(
764-
lambda self: self._d["leave_progress_bars"],
765-
lambda self, val: self._set_boolean("leave_progress_bars", val),
766-
doc="Whether to leave the progress bar for each animation.",
767-
)
768-
769766
@property
770767
def log_to_file(self):
771768
"""Whether to save logs to a file."""

manim/scene/scene.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -728,9 +728,9 @@ def get_time_progression(
728728
times,
729729
desc=description,
730730
total=n_iterations,
731-
leave=config["leave_progress_bars"],
731+
leave=config["progress_bar"] == "leave",
732732
ascii=True if platform.system() == "Windows" else None,
733-
disable=not config["progress_bar"],
733+
disable=config["progress_bar"] == "none",
734734
)
735735
return time_progression
736736

0 commit comments

Comments
 (0)