Skip to content

Conversation

@heba3
Copy link

@heba3 heba3 commented Jun 2, 2025


name: General PR template
about: A template with a generic and high-level review checklist, feel free to modify the checklists based on your PR.

General Checks

  • the branch is up to date with main
  • the code works when pulled and run locally
  • All CI checks pass (or at least discussed)
  • all conflicts are resolved (if any)
  • PR has a descriptive title
  • PR has appropriate labels and milestones for easy identification
  • PR it is assigned to the owner
  • reviewers are assigned
  • the PR contributes only one focused change
  • It is in the appropriate column in the project board (if necessary)
  • has short and clear description
  • is linked to an issue (if it is related)
  • feedback is addressed (if any and if it is appropriate feedback.)

Markdown

  • the markdown source is formatted
  • spelling and grammar is correct in all text
  • The markdown looks correct when you preview the file
  • all links and images work

@heba3 heba3 added the documentation Improvements or additions to documentation label Jun 2, 2025
@heba3 heba3 linked an issue Jun 2, 2025 that may be closed by this pull request
@heba3 heba3 self-assigned this Jun 2, 2025
@heba3 heba3 moved this to READY FOR REVIEW in ET6-CDSP-group-05-board Jun 2, 2025
@aandom aandom self-requested a review June 2, 2025 22:22
Copy link

@aandom aandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great

@aandom aandom moved this from READY FOR REVIEW to REVIEWING in ET6-CDSP-group-05-board Jun 2, 2025
@aandom aandom merged commit ddd9e15 into main Jun 2, 2025
10 checks passed
@aandom aandom moved this from REVIEWING to DONE in ET6-CDSP-group-05-board Jun 2, 2025
@aandom aandom added pull request This issue is for pull request and removed documentation Improvements or additions to documentation labels Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pull request This issue is for pull request

Projects

Development

Successfully merging this pull request may close these issues.

Add group norms

3 participants