Skip to content

milestone-1-retrospective PR resolves #23 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

milestone-1-retrospective PR resolves #23 #24

merged 1 commit into from
Jun 16, 2025

Conversation

@aandom
Copy link

@aandom aandom commented Jun 16, 2025

name: milestone-1-retrospective
about: A pull request for milestone 1 retrospective.

General Checks

  • the branch is up to date with main
  • the code works when pulled and run locally
  • All CI checks pass (or at least discussed)
  • all conflicts are resolved (if any)
  • PR has a descriptive title
  • PR has appropriate labels and milestones for easy identification
  • PR it is assigned to the owner
  • reviewers are assigned
  • the PR contributes only one focused change
  • It is in the appropriate column in the project board (if necessary)
  • has short and clear description
  • is linked to an issue (if it is related)
  • feedback is addressed (if any and if it is appropriate feedback.)

Markdown

  • the markdown source is formatted
  • spelling and grammar is correct in all text
  • The markdown looks correct when you preview the file
  • all links and images work

@aandom aandom added the pull request This issue is for pull request label Jun 16, 2025
@aandom aandom linked an issue Jun 16, 2025 that may be closed by this pull request
Milestone 1 Retrospective #23
Closed
@aandom aandom moved this to READY FOR REVIEW in ET6-CDSP-group-05-board Jun 16, 2025
@aandom aandom self-assigned this Jun 16, 2025
MD-Jubayer-Khan
MD-Jubayer-Khan approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@MD-Jubayer-Khan MD-Jubayer-Khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done

@github-project-automation github-project-automation bot moved this from READY FOR REVIEW to REVIEWING in ET6-CDSP-group-05-board Jun 16, 2025
@MD-Jubayer-Khan MD-Jubayer-Khan merged commit 4b4ebfe into main Jun 16, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from REVIEWING to DONE in ET6-CDSP-group-05-board Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MD-Jubayer-Khan MD-Jubayer-Khan MD-Jubayer-Khan approved these changes

Assignees

@aandom aandom

Labels

pull request This issue is for pull request

Projects

ET6-CDSP-group-05-board
Status: DONE

Milestone

Milestone 1 - Problem Identification

Development

Successfully merging this pull request may close these issues.

Milestone 1 Retrospective

3 participants

@aandom @MD-Jubayer-Khan