From d288e0e2194de8479b49d6612a5ca980e6f30896 Mon Sep 17 00:00:00 2001 From: Nikita Klimenko Date: Wed, 20 Sep 2023 16:52:22 +0300 Subject: [PATCH 1/3] fix samples compilation --- core/build.gradle.kts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/core/build.gradle.kts b/core/build.gradle.kts index 8d3d548133..2533e9df1b 100644 --- a/core/build.gradle.kts +++ b/core/build.gradle.kts @@ -79,7 +79,10 @@ val samplesImplementation by configurations.getting { } val compileSamplesKotlin = tasks.named("compileSamplesKotlin") { - friendPaths.from(sourceSets["main"].output.classesDirs) + tasks.named("compileTestKotlin").get().let { + friendPaths.from(it.friendPaths) + libraries.from(it.libraries) + } source(sourceSets["test"].kotlin) destinationDirectory.set(file("$buildDir/classes/testWithOutputs/kotlin")) } From 32bdda1fbd7f6cb76cc05548d0148d5d9c122653 Mon Sep 17 00:00:00 2001 From: Nikita Klimenko Date: Wed, 20 Sep 2023 16:53:03 +0300 Subject: [PATCH 2/3] add some explanations about samplesTest --- core/build.gradle.kts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/build.gradle.kts b/core/build.gradle.kts index 2533e9df1b..c4910c9bc7 100644 --- a/core/build.gradle.kts +++ b/core/build.gradle.kts @@ -46,6 +46,7 @@ kotlin.sourceSets { } sourceSets { + // Gradle creates configurations and compilation task for each source set create("samples") { kotlin.srcDir("src/test/kotlin") } @@ -106,7 +107,7 @@ val clearTestResults by tasks.creating(Delete::class) { val samplesTest = tasks.register("samplesTest") { group = "Verification" - description = "Runs the custom tests." + description = "Runs all samples that are used in the documentation, but modified to save their outputs to a file." dependsOn(compileSamplesKotlin) dependsOn(clearTestResults) From eba27b19fda530ff21d31c0b61b0d61078c5e4fe Mon Sep 17 00:00:00 2001 From: Nikita Klimenko Date: Wed, 20 Sep 2023 16:53:12 +0300 Subject: [PATCH 3/3] update korro --- docs/StardustDocs/topics/joinWith.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/StardustDocs/topics/joinWith.md b/docs/StardustDocs/topics/joinWith.md index 1bacce60e6..f03ef06ab0 100644 --- a/docs/StardustDocs/topics/joinWith.md +++ b/docs/StardustDocs/topics/joinWith.md @@ -68,7 +68,7 @@ campaigns.innerJoinWith(visits) { ```kotlin campaigns.innerJoinWith(visits) { - right[{ "date"() }] in "startDate"().."endDate"() + right.getValue("date") in "startDate"().."endDate"() } ``` @@ -108,7 +108,7 @@ campaigns.filterJoinWith(visits) { ```kotlin campaigns.filterJoinWith(visits) { - right[{ "date"() }] in "startDate"().."endDate"() + right.getValue("date") in "startDate"().."endDate"() } ``` @@ -146,7 +146,7 @@ campaigns.leftJoinWith(visits) { ```kotlin campaigns.leftJoinWith(visits) { - right[{ "date"() }] in "startDate"().."endDate"() + right.getValue("date") in "startDate"().."endDate"() } ``` @@ -184,7 +184,7 @@ campaigns.rightJoinWith(visits) { ```kotlin campaigns.rightJoinWith(visits) { - right[{ "date"() }] in "startDate"().."endDate"() + right.getValue("date") in "startDate"().."endDate"() } ``` @@ -222,7 +222,7 @@ campaigns.fullJoinWith(visits) { ```kotlin campaigns.fullJoinWith(visits) { - right[{ "date"() }] in "startDate"().."endDate"() + right.getValue("date") in "startDate"().."endDate"() } ``` @@ -262,7 +262,7 @@ campaigns.excludeJoinWith(visits) { ```kotlin campaigns.excludeJoinWith(visits) { - right[{ "date"() }] in "startDate"().."endDate"() + right.getValue("date") in "startDate"().."endDate"() } ```