Fix the read global properties backcompat issue #743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #740
Context
The original PR (#732) was quite loaded - one of the changes was making sure that full roundtrip of writing, reading binlog doesn't loose some minor details that would otherwise prevent full roundtrip equality check.
That change was had buggy conditions, but due to flood of other changes it slipped easily.
Fix made
For the previous version of logs we keep the old reading behavior of global props - first flag, then - if the flag is true - the dictionary. For new version of logs (yet to be produced) the dictionary is read allways.
Testing
Manual - the repro binlog, Orchard binlog and couple experimental binlogs of v 18 and above