Skip to content

[MUMPS_seq] Add the 64-bit integer version #8057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[MUMPS_seq] Add the 64-bit integer version #8057

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1182332
[MUMPS_seq] Add the 64-bit integer version
amontoison Feb 2, 2024
2e6e7dd
Try to isolate the error with the compiler
amontoison Feb 3, 2024
56a2866
Update FFLAGS
amontoison Feb 3, 2024
9d34d42
Try gcc v8
ViralBShah Feb 16, 2024
eab2b47
Update build_tarballs.jl
ViralBShah Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 44 additions & 4 deletions M/MUMPS/MUMPS_seq@5/build_tarballs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ using BinaryBuilder, Pkg

name = "MUMPS_seq"
upstream_version = v"5.6.2"
version_offset = v"0.0.1" # reset to 0.0.0 once the upstream version changes
version_offset = v"0.0.2" # reset to 0.0.0 once the upstream version changes
Copy link
Member

@ViralBShah ViralBShah Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't Yggdrasil just publish new versions as +1, +2, etc? Unless we are patching the package, I thought we wouldn't need to change the version_offset.

Copy link
Contributor Author

@amontoison amontoison Feb 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but for Coin packages and its dependencies, we multiply all version numbers by 100:
https://github.com/JuliaPackaging/Yggdrasil/blob/master/M/MUMPS/MUMPS_seq%405/build_tarballs.jl#L19-L21
We often recompile the same version of a package (like Ipopt) with updated dependencies (MUMPS, SPRAL, ...).
Without this trick, if the new version of the dependency breaks the package, all the Coin ecosystem is broken... (cc @odow 😛).

version = VersionNumber(upstream_version.major * 100 + version_offset.major,
upstream_version.minor * 100 + version_offset.minor,
upstream_version.patch * 100 + version_offset.patch)
Expand All @@ -35,8 +35,9 @@ cp Make.inc/${makefile} Makefile.inc

# Add `-fallow-argument-mismatch` if supported
: >empty.f
FFLAGS=()
if gfortran -c -fallow-argument-mismatch empty.f >/dev/null 2>&1; then
FFLAGS=("-fallow-argument-mismatch")
FFLAGS+=("-fallow-argument-mismatch")
fi
rm -f empty.*

Expand Down Expand Up @@ -74,6 +75,41 @@ make -j${nproc} allshared "${make_args[@]}"
mkdir ${includedir}/libseq
cp include/*.h ${includedir}
cp libseq/*.h ${includedir}/libseq
cp lib/*.${dlext} ${libdir}

make clean

for sym in isamax idamax ilaenv slamch dlamch \
saxpy scopy sgemm sgemv slarfg sorgqr sscal sswap strsv strsm snrm2 \
daxpy dcopy dgemm dgemv dlarfg dorgqr dscal dswap dtrsv dtrsm dnrm2 \
caxpy ccopy cgemm cgemv clarfg cungqr cscal cswap ctrsv ctrsm scnrm2 \
zaxpy zcopy zgemm zgemv zlarfg zungqr zscal zswap ztrsv ztrsm dznrm2
do
FFLAGS+=("-D${sym}=${sym}_64")
done
FFLAG="${FFLAGS[@]}"

make_args_64+=(PLAT="64"
OPTF="-O3 -fdefault-integer-8 -ffixed-line-length-none"
OPTL="-O3"
OPTC="-O3 -DINTSIZE64"
CDEFS=-DAdd_
LMETISDIR="${libdir}/metis/metis_Int64_Real32/lib"
IMETIS="-I${libdir}/metis_Int64_Real32/include"
LMETIS="-L${libdir}/metis/metis_Int64_Real32/lib -lmetis_Int64_Real32"
ORDERINGSF="-Dpord -Dmetis"
LIBEXT_SHARED=".${dlext}"
SONAME="${SONAME}"
CC="$CC ${CFLAGS[@]}"
FC="gfortran $FFLAG"
FL="gfortran"
RANLIB="echo"
LPORD="-L./PORD/lib -lpord64"
LIBBLAS="${BLAS_LAPACK}"
LAPACK="${BLAS_LAPACK}")

make allshared "${make_args_64[@]}"

cp lib/*.${dlext} ${libdir}
"""

Expand All @@ -85,14 +121,18 @@ products = [
LibraryProduct("libdmumps", :libdmumps),
LibraryProduct("libcmumps", :libcmumps),
LibraryProduct("libzmumps", :libzmumps),
LibraryProduct("libsmumps64", :libsmumps64),
LibraryProduct("libdmumps64", :libdmumps64),
LibraryProduct("libcmumps64", :libcmumps64),
LibraryProduct("libzmumps64", :libzmumps64),
]

# Dependencies that must be installed before this package can be built
dependencies = [
Dependency(PackageSpec(name="CompilerSupportLibraries_jll", uuid="e66e0078-7015-5450-92f7-15fbd957f2ae")),
Dependency(PackageSpec(name="METIS_jll", uuid="d00139f3-1899-568f-a2f0-47f597d42d70")),
Dependency(PackageSpec(name="libblastrampoline_jll", uuid="8e850b90-86db-534c-a0d3-1478176c7d93"), compat="5.4.0"),
Dependency(PackageSpec(name="libblastrampoline_jll", uuid="8e850b90-86db-534c-a0d3-1478176c7d93"), compat="5.4.0")
]

# Build the tarballs
build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies, julia_compat = "1.9", preferred_gcc_version=v"6")
build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies, julia_compat="1.9", preferred_gcc_version=v"6")