Avoid using mktemp -p
#60091
Merged
Avoid using mktemp -p
#60091
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
What about the same exact pattern in https://github.com/JuliaLang/julia/pull/60080/files#diff-cb2331105d65a4d04039008fe1918d2ebb39ec4b5cda8dbc0576c2afa427b211L83 and https://github.com/JuliaLang/julia/pull/60080/files#diff-bd732106e159858a9f4df78a5703830f75093d230c2e094596f2a31e32b36f30L145? Shouldn't they also be changed in exactly the same way? |
Member
Author
|
Indeed, thanks |
fingolfin
force-pushed
the
mh/Makefile-mktemp-darwin
branch
from
014bdd5 to
d28fa40
Compare
It is not supported in macOS 13 userland which causes CI failures. Also clean the temp files if necessary.
fingolfin
force-pushed
the
mh/Makefile-mktemp-darwin
branch
from
d28fa40 to
844bdd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not supported in macOS 13 userland which causes CI failures. For background info see here.
This is a subset of PR #60080 but unlike that, it only solves the specific issue causing trouble in CI right now, and does not attempt to resolve a bunch of other things -- which may very well all be fine and nice and desirable, but it's quite a bit more to review.