remove :boundscheck argument from Core._svec_ref
#50561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Core._svec_ref` has accepted `boundscheck`-value as the first argument since it was added in #45062. Nonetheless, `Core._svec_ref` simply calls `jl_svec_ref` in either the interpreter or the codegen, and thus the `boundscheck` value isn't utilized in any optimizations. Rather, even worse, this `boundscheck`-argument negatively influences the effect analysis (xref #50167 for details) and has caused type inference regressions as reported in #50544. For these reasons, this commit simply eliminates the `boundscheck` argument from `Core._svec_ref`. Consequently, `getindex(::SimpleVector, ::Int)` is now being concrete-eval eligible. closes #50544
Keno
approved these changes
Jul 15, 2023
vtjnash
reviewed
Jul 15, 2023
Member
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
I am surprised inference and codegen don't have any opinion about this
KristofferC
added
the
backport 1.10
Member
Author
|
|
aviatesk
added a commit
that referenced
this pull request
Jul 17, 2023
`Core._svec_ref` has accepted `boundscheck`-value as the first argument since it was added in #45062. Nonetheless, `Core._svec_ref` simply calls `jl_svec_ref` in either the interpreter or the codegen, and thus the `boundscheck` value isn't utilized in any optimizations. Rather, even worse, this `boundscheck`-argument negatively influences the effect analysis (xref #50167 for details) and has caused type inference regressions as reported in #50544. For these reasons, this commit simply eliminates the `boundscheck` argument from `Core._svec_ref`. Consequently, `getindex(::SimpleVector, ::Int)` is now being concrete-eval eligible. closes #50544
45 tasks
aviatesk
removed
the
backport 1.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core._svec_refhas acceptedboundscheck-value as the first argument since it was added in #45062. Nonetheless,Core._svec_refsimply callsjl_svec_refin either the interpreter or the codegen, and thus theboundscheckvalue isn't utilized in any optimizations. Rather, even worse, thisboundscheck-argument negatively influences the effect analysis (xref #50167 for details) and has caused type inference regressions as reported in #50544.For these reasons, this commit simply eliminates the
boundscheckargument fromCore._svec_ref. Consequently,getindex(::SimpleVector, ::Int)is now being concrete-eval eligible.closes #50544