Skip to content

Do not segfault on displaysize(tty) after close(tty) #34623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 30, 2020
Merged

Do not segfault on displaysize(tty) after close(tty) #34623

merged 7 commits into from
Apr 30, 2020

Conversation

@tkf
Copy link
Member

@tkf tkf commented Feb 1, 2020

close #34620

vtjnash
vtjnash reviewed Feb 1, 2020
View reviewed changes
@tkf
Copy link
Member Author

tkf commented Feb 3, 2020

Tests on Windows failed with

Error in testset misc:
Error During Test at D:\buildbot\worker-tabularasa\tester_win64\build\share\julia\test\misc.jl:527
  Got exception outside of a @test
  IOError: TTY: bad file descriptor (EBADF)
  Stacktrace:
   [1] uv_error at .\libuv.jl:97 [inlined]
   [2] Base.TTY(::Base.Libc.WindowsRawSocket) at .\stream.jl:193
   [3] (::Main.Test64Main_misc.var"#25#26")(::Base.Libc.WindowsRawSocket, ::Base.PipeEndpoint) at D:\buildbot\worker-tabularasa\tester_win64\build\share\julia\test\misc.jl:529
   [4] with_fake_pty(::Main.Test64Main_misc.var"#25#26") at D:\buildbot\worker-tabularasa\tester_win64\build\share\julia\test\testhelpers\FakePTYs.jl:58
   [5] top-level scope at D:\buildbot\worker-tabularasa\tester_win64\build\share\julia\test\misc.jl:528

Does FakePTYs work on Windows? Or am I misusing it?

@tkf tkf mentioned this pull request Feb 4, 2020
Open
vtjnash
vtjnash reviewed Apr 28, 2020
View reviewed changes
@vtjnash
Copy link
Member

vtjnash commented Apr 29, 2020

This needs a rebase or merge with master to pick up CI fixes

@tkf tkf requested a review from vtjnash April 30, 2020 01:32
@vtjnash vtjnash merged commit 55671a1 into JuliaLang:master Apr 30, 2020
@tkf tkf deleted the displaysize-tty branch April 30, 2020 05:39
@vtjnash vtjnash mentioned this pull request Apr 9, 2021
Closed
@gbaraldi gbaraldi mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

displaysize(tty) after close(tty) segfaults

2 participants

@tkf @vtjnash