fixup pass names

Author: KristofferC

Compiler/test/inline.jl

@@ -1849,7 +1849,7 @@ multi_inlining1(a::Int, b::Int) = @noinline func_mul_int(a, b)
 let i::Int, continue_::Bool
     interp = Compiler.NativeInterpreter()
     # check if callsite `@noinline` annotation works
-    ir, = only(Base.code_ircode(multi_inlining1, (Int,Int); optimize_until="inlining", interp))
+    ir, = only(Base.code_ircode(multi_inlining1, (Int,Int); optimize_until="Inlining", interp))
     i = findfirst(isinvoke(:func_mul_int), ir.stmts.stmt)
     @test i !== nothing
     # now delete the callsite flag, and see the second inlining pass can inline the call
@@ -1873,7 +1873,7 @@ multi_inlining2(a::Int, b::Int) = call_func_mul_int(a, b)
 let i::Int, continue_::Bool
     interp = Compiler.NativeInterpreter()
     # check if callsite `@noinline` annotation works
-    ir, = only(Base.code_ircode(multi_inlining2, (Int,Int); optimize_until="inlining", interp))
+    ir, = only(Base.code_ircode(multi_inlining2, (Int,Int); optimize_until="Inlining", interp))
     i = findfirst(isinvoke(:func_mul_int), ir.stmts.stmt)
     @test i !== nothing
     # now delete the callsite flag, and see the second inlining pass can inline the call

Compiler/test/irpasses.jl

@@ -920,7 +920,9 @@ let # Test that CFG simplify doesn't try to merge every block in a loop into
 end
 
 # `cfg_simplify!` shouldn't error in a presence of `try/catch` block
-let ir = Base.code_ircode(; optimize_until="slot2ssa") do
+# XXX: There used to be a `"optimize_until="slot2ssa"` in the `code_ircode` call below
+# but there is no pass with that name.
+let ir = Base.code_ircode() do
         v = try
         catch
         end
@@ -1458,7 +1460,9 @@ function f_with_early_try_catch_exit()
     result
 end
 
-let ir = first(only(Base.code_ircode(f_with_early_try_catch_exit, (); optimize_until="compact")))
+# XXX: There used to be a `optimize_until="compact"` in the `code_ircode` call below
+# but there is no pass with that name.
+let ir = first(only(Base.code_ircode(f_with_early_try_catch_exit, ())))
     for i = 1:length(ir.stmts)
         expr = ir.stmts[i][:stmt]
         if isa(expr, PhiCNode)

Compiler/test/ssair.jl

@@ -597,7 +597,10 @@ import Core: SSAValue
 import .Compiler: NewInstruction, insert_node!
 
 # insert_node! for pending node
-let ir = Base.code_ircode((Int,Int); optimize_until="inlining") do a, b
+# XXX: There used to be an `optimize_until="inlining"` in the `code_ircode` call below
+# but there is no pass with that name (there is a pass called "Inlining" but fixing that typo
+# makes the test fail
+let ir = Base.code_ircode((Int,Int)) do a, b
         a^b
     end |> only |> first
     nstmts = length(ir.stmts)
@@ -658,7 +661,10 @@ let code = Any[
 end
 
 # insert_node! with new instruction with flag computed
-let ir = Base.code_ircode((Int,Int); optimize_until="inlining") do a, b
+# XXX: There used to be an `optimize_until="inlining"` in the `code_ircode` call below
+# but there is no pass with that name (there is a pass called "Inlining" but fixing that typo
+# makes the test fail
+let ir = Base.code_ircode((Int,Int)) do a, b
         a^b
     end |> only |> first
     invoke_idx = findfirst(@nospecialize(stmt)->Meta.isexpr(stmt, :invoke), ir.stmts.stmt)