atomics: fix setonce runtime intrinsic (#55530)

vtjnash · KristofferC · commit 9c7bfec5cab9 · 2024-09-12T10:24:16.000+02:00
diff --git a/src/datatype.c b/src/datatype.c
@@ -2188,7 +2188,7 @@ inline int setonce_bits(jl_datatype_t *rty, char *p, jl_value_t *parent, jl_valu
     }
     else {
         char *px = lock(p, parent, needlock, isatomic);
-        success = undefref_check(rty, (jl_value_t*)px) != NULL;
+        success = undefref_check(rty, (jl_value_t*)px) == NULL;
         if (success)
             memassign_safe(hasptr, px, rhs, fsz);
         unlock(p, parent, needlock, isatomic);
diff --git a/test/atomics.jl b/test/atomics.jl
@@ -319,6 +319,7 @@ test_field_orderings(ARefxy{Union{Nothing,Missing}}(nothing, missing), nothing,
 test_field_orderings(ARefxy{Union{Nothing,Int}}(nothing, 123_1), nothing, 123_1)
 test_field_orderings(Complex{Int128}(10, 30), Complex{Int128}(20, 40))
 test_field_orderings(Complex{Real}(10, 30), Complex{Real}(20, 40))
+test_field_orderings(Complex{Rational{Integer}}(10, 30), Complex{Rational{Integer}}(20, 40))
 test_field_orderings(10.0, 20.0)
 test_field_orderings(NaN, Inf)
 

Original file line number	Diff line number	Diff line change
`@@ -2188,7 +2188,7 @@ inline int setonce_bits(jl_datatype_t rty, char p, jl_value_t *parent, jl_valu`
`2188`	`2188`	`}`
`2189`	`2189`	`else {`
`2190`	`2190`	`char *px = lock(p, parent, needlock, isatomic);`
`2191`		`- success = undefref_check(rty, (jl_value_t*)px) != NULL;`
	`2191`	`+ success = undefref_check(rty, (jl_value_t*)px) == NULL;`
`2192`	`2192`	`if (success)`
`2193`	`2193`	`memassign_safe(hasptr, px, rhs, fsz);`
`2194`	`2194`	`unlock(p, parent, needlock, isatomic);`