Do not print leading newline in _show_with_braille_patterns

Author: goggle

stdlib/SparseArrays/src/sparsematrix.jl

@@ -271,7 +271,6 @@ function _show_with_braille_patterns(io::IOContext, S::AbstractSparseMatrixCSC)
             brailleGrid[k, l] |= brailleBlocks[p]
         end
     end
-    println(io)
     foreach(c -> print(io, Char(c)), @view brailleGrid[1:end-1])
 end
 
@@ -282,6 +281,7 @@ function Base.show(io::IOContext, S::AbstractSparseMatrixCSC)
         Base.print_matrix(ioc, S)
         return
     end
+    println(io)
     _show_with_braille_patterns(io, S)
 end
 

stdlib/SparseArrays/test/sparse.jl

@@ -2232,37 +2232,37 @@ end
     show(io, MIME"text/plain"(), A)
     @test String(take!(io)) == "1×2 SparseArrays.SparseMatrixCSC{Float64,Int64} with 2 stored entries:\n 1.0  2.0"
     _show_with_braille_patterns(convert(IOContext, io), A)
-    @test String(take!(io)) == "\n⠉"
+    @test String(take!(io)) == "⠉"
 
     # every 1-dot braille pattern
     for (i, b) in enumerate(split("⠁⠂⠄⡀⠈⠐⠠⢀", ""))
         A = spzeros(Int64, Int64, 4, 2)
         A[i] = 1
         _show_with_braille_patterns(convert(IOContext, io), A)
-        @test String(take!(io)) == "\n" * b
+        @test String(take!(io)) == b
     end
 
     # empty braille pattern Char(10240)
     A = spzeros(Int64, Int64, 4, 2)
     _show_with_braille_patterns(convert(IOContext, io), A)
-    @test String(take!(io)) == "\n" * Char(10240)
+    @test String(take!(io)) == "" * Char(10240)
 
     A = sparse(Int64[1, 2, 4, 2, 3], Int64[1, 1, 1, 2, 2], Int64[1, 1, 1, 1, 1], 4, 2)
     show(io, MIME"text/plain"(), A)
     @test String(take!(io)) == "4×2 SparseArrays.SparseMatrixCSC{Int64,Int64} with 5 stored entries:\n 1  ⋅\n 1  1\n ⋅  1\n 1  ⋅"
     _show_with_braille_patterns(convert(IOContext, io), A)
-    @test String(take!(io)) == "\n⡳"
+    @test String(take!(io)) == "⡳"
 
     A = sparse(Int64[1, 3, 2, 4], Int64[1, 1, 2, 2], Int64[1, 1, 1, 1], 7, 3)
     show(io, MIME"text/plain"(), A)
     @test String(take!(io)) == "7×3 SparseArrays.SparseMatrixCSC{Int64,Int64} with 4 stored entries:\n 1  ⋅  ⋅\n ⋅  1  ⋅\n 1  ⋅  ⋅\n ⋅  1  ⋅\n ⋅  ⋅  ⋅\n ⋅  ⋅  ⋅\n ⋅  ⋅  ⋅"
     _show_with_braille_patterns(convert(IOContext, io), A)
-    @test String(take!(io)) == "\n⢕" * Char(10240) * "\n" * Char(10240)^2
+    @test String(take!(io)) == "⢕" * Char(10240) * "\n" * Char(10240)^2
 
     A = sparse(Int64[1:10;], Int64[1:10;], fill(Float64(1), 10))
     _show_with_braille_patterns(convert(IOContext, io), A)
     brailleString = "⠑⢄" * Char(10240)^3 * "\n" * Char(10240)^2 * "⠑⢄" * Char(10240) * "\n" * Char(10240)^4 * "⠑"
-    @test String(take!(io)) == "\n" * brailleString
+    @test String(take!(io)) == brailleString
 
     function _filled_sparse(m::Integer, n::Integer)
         C = CartesianIndices((m, n))[:]
@@ -2274,18 +2274,18 @@ end
     # vertical scaling
     ioc = IOContext(io, :displaysize => (5, 80), :limit => true)
     _show_with_braille_patterns(ioc, _filled_sparse(10, 10))
-    @test String(take!(io)) == "\n" * "⣿⣿"
+    @test String(take!(io)) == "⣿⣿"
 
     _show_with_braille_patterns(ioc, _filled_sparse(20, 10))
-    @test String(take!(io)) == "\n" * "⣿"
+    @test String(take!(io)) == "⣿"
 
     # horizontal scaling
     ioc = IOContext(io, :displaysize => (80, 4), :limit => true)
     _show_with_braille_patterns(ioc, _filled_sparse(8, 8))
-    @test String(take!(io)) == "\n" * "⣿⣿"
+    @test String(take!(io)) == "⣿⣿"
 
     _show_with_braille_patterns(ioc, _filled_sparse(8, 16))
-    @test String(take!(io)) == "\n" * "⠛⠛"
+    @test String(take!(io)) == "⠛⠛"
 end
 
 @testset "check buffers" for n in 1:3