add and extend unit tests #7685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koppor
requested changes
May 2, 2021
Member
koppor
left a comment
koppor
left a comment
There was a problem hiding this comment.
Nice that there are some tests for logic added. Some nitpick comments 😇
src/test/java/org/jabref/logic/formatter/bibtexfields/AddBracesFormatterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/integrity/ValidCitationKeyCheckerTest.java
Outdated
Show resolved
Hide resolved
koppor
added
the
dev: code-quality
koppor
approved these changes
May 3, 2021
koppor
requested changes
May 3, 2021
src/test/java/org/jabref/logic/integrity/ValidCitationKeyCheckerTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Oliver Kopp <[email protected]>
koppor
requested changes
May 3, 2021
src/test/java/org/jabref/logic/integrity/ValidCitationKeyCheckerTest.java
Outdated
Show resolved
Hide resolved
koppor
approved these changes
May 6, 2021
Siedlerchr
added a commit
that referenced
this pull request
May 15, 2021
* upstream/main: (71 commits) [Bot] Update CSL styles (#7735) Fix for issue 6966: open all files of multiple entries (#7709) Add simple unit tests (#7696) Add simple unit tests (#7543) Update check-outdated-dependencies.yml Added preset for new entry keybindings and reintroduced defaults (#7705) Select the entry which has smaller dictonary order when merge (#7708) Update CHANGELOG.md fix: make more fields, fomatters, ids and languages sorted by alphabetical order (#7717) Bump libreoffice from 7.1.2 to 7.1.3 (#7721) Bump unoloader from 7.1.2 to 7.1.3 (#7724) Bump org.beryx.jlink from 2.23.7 to 2.23.8 (#7723) Bump org.openjfx.javafxplugin from 0.0.9 to 0.0.10 (#7725) fix: make fields sorted by lexicographical order (#7711) Fix tests Refactoring existing unit tests (#7687) Refactoring and addition of unit tests (#7581) Refactor simple Unit Tests (#7571) Add simple unit tests (#7544) add and extend unit tests (#7685) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contributes to issue #6207, which is to add more unit tests to the project.
Tests added:
ValidCitationKeyCheckerTest
Tests extended (added boundary cases):
AddBracesFormatterTest
NormalizePagesFormatterTest
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)