Clean-up claw-jsonld

[ruebot]

Digging into a build issue with claw-jsonld causing the build to fail, and I'm noticing a number of basic issues that need to be addressed:

• https://github.com/Islandora-CLAW/claw-jsonld/blob/8.x-1.x/composer.json#L6-L10
  • Needs an Islandora Foundation owner added
• https://github.com/Islandora-CLAW/claw-jsonld/blob/8.x-1.x/jsonld.info.yml#L1
  • The name of the repo is not consistent with the name of the module
• https://github.com/Islandora-CLAW/claw-jsonld/blob/8.x-1.x/jsonld.info.yml#L5-L6
  • Why is this commented out?
• https://github.com/Islandora-CLAW/claw-jsonld/blob/8.x-1.x/jsonld.services.yml#L3
  • What is Drupal\jsonld? I can't find it anywhere, other then jsonld mentions in this module. Is that the name of the module or something else?
• https://github.com/Islandora-CLAW/claw-jsonld/blob/8.x-1.x/jsonld.module#L20-L27
  • What is this? Do we need all of that?

[DiegoPino]

Some general comments about the basic issues you detected: most of the things have been around for many months already or have nothing to do with this module failing. JSON-LD normalization and serialization for GET operations was/has been working all that time.

Fourth Question: Drupal\jsonld is the PHP namespace. Not sure if that line is pointing to your question if so, it points to this class https://github.com/Islandora-CLAW/claw-jsonld/blob/8.x-1.x/src/Normalizer/EntityReferenceItemNormalizer.php#L13 which is correct. I'm pretty sure you know how the symfony autoloader works.

Fifth Question: This one is weird. You asked me close a issue about CLAW-JSONLD because it had too many dispair requirements. So, please, how a stub Module description, copied from the JSON-LD website`s definition, needs a) and explanation b) is that type code coding normed in CLAW? Like what we need to say, write? For sure we don't need it. What then, what do we need?

The whole issue of CLAW-JSONLD failing , as commented in Islandora/Crayfish#20 is because the REST module link manager Service does not exist when enabling the serializer. Happens that on Drupal 8.3 they moved that service into HAL because they never imagined someone else would need to make that happen (wrong architectural choice..)

https://www.drupal.org/node/2758897
https://www.drupal.org/node/2854830

Which is all wrong, but it is what it is.

Since https://github.com/Islandora-CLAW/drupal-project/blame/8.x-1.x/composer.json
Is kinda free-form allowing always the latest version of Drupal to be installed, without me testing my affirmations of course, i would guess that ~8.0 https://github.com/Islandora-CLAW/drupal-project/blame/8.x-1.x/composer.json#L23 means anything higher that is stable, which is in this case Drupal 8.3.

Solution: enable HAL Module. If not, and we are on 8.2 still, then REST is not being enabled at all. But i would put my cards on 8.3 and HAL mix.

[ruebot]

PR: Islandora/jsonld#17

[ruebot]

PR: islandora-deprecated/drupal-project#12

[ruebot]

Partially addressed with: islandora-deprecated/drupal-project@0c7090a

[ruebot]

Partially resolved with: Islandora/jsonld@5c981a7

[ruebot]

Only remaining item here from my perspective is the name of the repository. The module name is jsonld. I think we should change the name of the repo to that. Do any @Islandora-CLAW/committers feel differently?

[whikloj]

👍 Change it, I've had that confuse me a couple times.

[dannylamb]

👍 for changing the repo to jsonld

[ruebot]

Changed.