fix(IAM Identity): add delete link with parameter api #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somchavan
force-pushed
the
iam-identity-link-del
branch
2 times, most recently
from
5b3a4b0 to
9f61823
Compare
pyrooka
requested changes
Aug 19, 2025
Member
pyrooka
left a comment
pyrooka
left a comment
There was a problem hiding this comment.
A few little things to change, otherwise it looks good.
Comment on lines
-2009
to
+2040
| preference is not None | ||
| assert preference is not None |
Member
There was a problem hiding this comment.
Wow, nice catch! I'm surprised the linter didn't flags this as a problem.
Comment on lines
1093
to
1094
| CreateProfileLinkRequestLink['component_name'] = 'test_componenet_name' | ||
| CreateProfileLinkRequestLink['component_type'] = 'test_componenet_type' |
Member
There was a problem hiding this comment.
I think this is s typo. :)
Suggested change
| CreateProfileLinkRequestLink['component_name'] = 'test_componenet_name' | |
| CreateProfileLinkRequestLink['component_type'] = 'test_componenet_type' | |
| CreateProfileLinkRequestLink['component_name'] = 'test_component_name' | |
| CreateProfileLinkRequestLink['component_type'] = 'test_component_type' |
Comment on lines
909
to
910
| CreateProfileLinkRequestLink['component_name'] = 'component_name' | ||
| CreateProfileLinkRequestLink['component_type'] = 'test_componenet_type' |
Member
There was a problem hiding this comment.
Just to be consistent. :)
Suggested change
| CreateProfileLinkRequestLink['component_name'] = 'component_name' | |
| CreateProfileLinkRequestLink['component_type'] = 'test_componenet_type' | |
| CreateProfileLinkRequestLink['component_name'] = 'test_component_name' | |
| CreateProfileLinkRequestLink['component_type'] = 'test_component_type' |
Signed-off-by: Somanath Chavan <[email protected]>
Somchavan
force-pushed
the
iam-identity-link-del
branch
from
1ff0119 to
08b53a6
Compare
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Aug 22, 2025
## [0.68.2](v0.68.1...v0.68.2) (2025-08-22) ### Bug Fixes * **IAM Identity:** add delete link with parameter api ([#299](#299)) ([f330d3c](f330d3c))
|
🎉 This PR is included in version 0.68.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
delete trusted profile link with parameters api
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information