Skip to content

Conversation

@benbuchanan
Copy link
Contributor

PR summary

These fields use an interface{} type in golang and support being an array or an object, so cannot be supported by the SDK or the oneOf definitions in swagger. These are deeply nested metadata fields that aren't necessary in the SDK, and were only just recently added but caused some errors because of invalid types. So we just want to remove them.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Just removing unnecessary fields.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

integration:

python3 -m pytest test/integration/test_global_catalog_v1.py
===================================================================== test session starts =====================================================================
platform darwin -- Python 3.13.2, pytest-7.4.4, pluggy-1.6.0
rootdir: /Users/benbuchanan/Developer/platform-services-python-sdk
plugins: cov-4.1.0
collected 27 items                                                                                                                                            

test/integration/test_global_catalog_v1.py ...........................                                                                                  [100%]

====================================================================== warnings summary =======================================================================
test/integration/test_global_catalog_v1.py: 14 warnings
  /Users/benbuchanan/Developer/platform-services-python-sdk/venv/lib/python3.13/site-packages/ibm_cloud_sdk_core/api_exception.py:56: DeprecationWarning: Using the `code` attribute on the `ApiException` is deprecated and will be removed in the future. Use `status_code` instead.
    warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============================================================== 27 passed, 14 warnings in 16.12s ===============================================================

example:

python3 -m pytest examples/test_global_catalog_v1_examples.py
===================================================================== test session starts =====================================================================
platform darwin -- Python 3.13.2, pytest-7.4.4, pluggy-1.6.0
rootdir: /Users/benbuchanan/Developer/platform-services-python-sdk
plugins: cov-4.1.0
collected 15 items                                                                                                                                            

examples/test_global_catalog_v1_examples.py ...............                                                                                             [100%]

===================================================================== 15 passed in 4.85s ======================================================================

@pyrooka pyrooka changed the title fix(GlobalCatalog): remove bad metadata fields fix(Global Catalog): remove bad metadata fields Jul 17, 2025
@pyrooka pyrooka self-requested a review July 17, 2025 10:35
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pyrooka pyrooka merged commit c8e49fc into IBM:main Jul 17, 2025
9 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Jul 17, 2025
## [0.67.1](v0.67.0...v0.67.1) (2025-07-17)

### Bug Fixes

* **Global Catalog:** remove bad metadata fields ([#297](#297)) ([c8e49fc](c8e49fc))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.67.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants