Skip to content

feat(Global Tagging): regenerate service with latest API definition #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 9, 2025
Merged

feat(Global Tagging): regenerate service with latest API definition #295

merged 9 commits into from
Jul 9, 2025

Conversation

@francescadecicco
Copy link
Contributor

@francescadecicco francescadecicco commented Jul 1, 2025 •
edited
Loading

Added new body parameter to attach/detach tags apis

ITs:
Screenshot 2025-07-04 at 12 17 33

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLAassistant commented Jul 1, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

pyrooka
pyrooka requested changes Jul 3, 2025
View reviewed changes
Copy link
Member

@pyrooka pyrooka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your Go SDK PR you updated the examples. Could you make the same change here, just to be consistent? All the other changes are looking good.
And please attach the result of the integration test run!

@pyrooka pyrooka changed the title fix(Global Search/Tagging): regenerated services with latest API definition fix(Global Search/Tagging): regenerate services with latest API definition Jul 3, 2025
@pyrooka pyrooka changed the title fix(Global Search/Tagging): regenerate services with latest API definition feat(Global Search/Tagging): regenerate services with latest API definition Jul 3, 2025
@pyrooka pyrooka changed the title feat(Global Search/Tagging): regenerate services with latest API definition feat(Global Tagging): regenerate service with latest API definition Jul 9, 2025
@pyrooka
fix: remove unused variable
bf25693 
Signed-off-by: Norbert Biczo <[email protected]>
pyrooka
pyrooka approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pyrooka pyrooka merged commit 649c1a1 into main Jul 9, 2025
15 checks passed
@pyrooka pyrooka deleted the tags_by_query branch July 9, 2025 10:03
ibm-devx-sdk pushed a commit that referenced this pull request Jul 9, 2025
@semantic-release-bot
chore(release): 0.67.0 release notes
5b326ee 
# [0.67.0](v0.66.2...v0.67.0) (2025-07-09)

### Features

* **Global Tagging:** regenerate service with latest API definition ([#295](#295)) ([649c1a1](649c1a1))
@ibm-devx-sdk
Copy link

ibm-devx-sdk commented Jul 9, 2025

🎉 This PR is included in version 0.67.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyrooka pyrooka pyrooka approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@francescadecicco @CLAassistant @ibm-devx-sdk @pyrooka