Skip to content

Conversation

@siddhuvarma1997
Copy link
Contributor

@siddhuvarma1997 siddhuvarma1997 commented Jul 1, 2024

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLAassistant commented Jul 1, 2024

CLA assistant check
All committers have signed the CLA.

@siddhuvarma1997
Copy link
Contributor Author

Integration tests:
image

@siddhuvarma1997 siddhuvarma1997 marked this pull request as ready for review July 1, 2024 20:37
@pyrooka pyrooka self-requested a review July 3, 2024 13:17
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please sign the CLA! And please attach the result of the example tests too.

@siddhuvarma1997
Copy link
Contributor Author

example tests:
image

@pyrooka
Copy link
Member

pyrooka commented Jul 4, 2024

@siddhuvarma1997 @siddhualluri you both must sign the CLA before we can merge this PR. All you need to do is open the link the following comment and click on the button: #262 (comment)

@pyrooka pyrooka changed the title fix(IAM Policy Assignment): S2S Policy Assignments fix(IAM Policy Management): remove options property from PolicyAssignment Jul 5, 2024
@pyrooka pyrooka merged commit 3283f3b into IBM:main Jul 5, 2024
ibm-devx-sdk pushed a commit that referenced this pull request Jul 5, 2024
## [0.54.2](v0.54.1...v0.54.2) (2024-07-05)

### Bug Fixes

* **IAM Policy Management:** remove `options` property from PolicyAssignment ([#262](#262)) ([3283f3b](3283f3b))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.54.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants