Skip to content

Conversation

@namratabhadauriya
Copy link
Contributor

@namratabhadauriya namratabhadauriya commented Apr 1, 2024

PR summary

add options property to create_account payload

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2024

CLA assistant check
All committers have signed the CLA.

…ld in createchild acc payload

Signed-off-by: namratabhadauriya <[email protected]>
@namratabhadauriya namratabhadauriya force-pushed the update_enterprise-managment branch from 4a2c2f0 to 3783e4c Compare April 1, 2024 06:39
Signed-off-by: namratabhadauriya <[email protected]>
@padamstx padamstx self-assigned this Apr 1, 2024
@padamstx padamstx self-requested a review April 1, 2024 15:38
@padamstx
Copy link
Contributor

padamstx commented Apr 1, 2024

Just a reminder that we need to re-gen the SDK code with the latest version of the generator (3.87.0).
Also, be sure to run make lint (and fix any lint errors by running make lint-fix or making manual changes as needed) prior to pushing your changes

@padamstx padamstx changed the title feat(Enterprise Management) : re-gen service after adding options fie… fix(Enterprise Management): add options property to create_account payload Apr 1, 2024
Copy link
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namratabhadauriya
Copy link
Contributor Author

image

@padamstx padamstx merged commit 4aeff97 into main Apr 2, 2024
@padamstx padamstx deleted the update_enterprise-managment branch April 2, 2024 15:51
ibm-devx-sdk pushed a commit that referenced this pull request Apr 2, 2024
## [0.53.1](v0.53.0...v0.53.1) (2024-04-02)

### Bug Fixes

* **Enterprise Management:** add options property to create_account payload ([#250](#250)) ([4aeff97](4aeff97))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.53.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants