Remove legacy forward slash syntax support from SpectreArgumentParser and update tests to use POSIX syntax

Co-authored-by: arturcic <[email protected]>

Author: Copilot

src/GitVersion.App.Tests/ArgumentParserTests.cs

@@ -220,7 +220,7 @@ public void WrongNumberOfArgumentsShouldThrow()
     }
 
     [TestCase("targetDirectoryPath -x logFilePath")]
-    [TestCase("/invalid-argument")]
+    [TestCase("--invalid-argument")]
     public void UnknownArgumentsShouldThrow(string arguments)
     {
         var exception = Assert.Throws<WarningException>(() => this.argumentParser.ParseArguments(arguments));
@@ -370,14 +370,14 @@ public void UpdateAssemblyInfoWithRelativeFilename()
     [Test]
     public void OverrideconfigWithNoOptions()
     {
-        var arguments = this.argumentParser.ParseArguments("/overrideconfig");
+        var arguments = this.argumentParser.ParseArguments("--override-config");
         arguments.OverrideConfiguration.ShouldBeNull();
     }
 
     [TestCaseSource(nameof(OverrideconfigWithInvalidOptionTestData))]
     public string OverrideconfigWithInvalidOption(string options)
     {
-        var exception = Assert.Throws<WarningException>(() => this.argumentParser.ParseArguments($"/overrideconfig {options}"));
+        var exception = Assert.Throws<WarningException>(() => this.argumentParser.ParseArguments($"--override-config {options}"));
         exception.ShouldNotBeNull();
         return exception.Message;
     }
@@ -386,18 +386,18 @@ private static IEnumerable<TestCaseData> OverrideconfigWithInvalidOptionTestData
     {
         yield return new TestCaseData("tag-prefix=sample=asdf")
         {
-            ExpectedResult = "Could not parse /overrideconfig option: tag-prefix=sample=asdf. Ensure it is in format 'key=value'."
+            ExpectedResult = "Could not parse --override-config option: tag-prefix=sample=asdf. Ensure it is in format 'key=value'."
         };
         yield return new TestCaseData("unknown-option=25")
         {
-            ExpectedResult = "Could not parse /overrideconfig option: unknown-option=25. Unsupported 'key'."
+            ExpectedResult = "Could not parse --override-config option: unknown-option=25. Unsupported 'key'."
         };
     }
 
     [TestCaseSource(nameof(OverrideConfigWithSingleOptionTestData))]
     public void OverrideConfigWithSingleOptions(string options, IGitVersionConfiguration expected)
     {
-        var arguments = this.argumentParser.ParseArguments($"/overrideconfig {options}");
+        var arguments = this.argumentParser.ParseArguments($"--override-config {options}");
 
         ConfigurationHelper configurationHelper = new(arguments.OverrideConfiguration);
         configurationHelper.Configuration.ShouldBeEquivalentTo(expected);
@@ -551,23 +551,23 @@ public void OverrideConfigWithMultipleOptions(string options, IGitVersionConfigu
     private static IEnumerable<TestCaseData> OverrideConfigWithMultipleOptionsTestData()
     {
         yield return new TestCaseData(
-            "/overrideconfig tag-prefix=sample /overrideconfig assembly-versioning-scheme=MajorMinor",
+            "--override-config tag-prefix=sample --override-config assembly-versioning-scheme=MajorMinor",
             new GitVersionConfiguration
             {
                 TagPrefixPattern = "sample",
                 AssemblyVersioningScheme = AssemblyVersioningScheme.MajorMinor
             }
         );
         yield return new TestCaseData(
-            "/overrideconfig tag-prefix=sample /overrideconfig assembly-versioning-format=\"{Major}.{Minor}.{Patch}.{env:CI_JOB_ID ?? 0}\"",
+            "--override-config tag-prefix=sample --override-config assembly-versioning-format=\"{Major}.{Minor}.{Patch}.{env:CI_JOB_ID ?? 0}\"",
             new GitVersionConfiguration
             {
                 TagPrefixPattern = "sample",
                 AssemblyVersioningFormat = "{Major}.{Minor}.{Patch}.{env:CI_JOB_ID ?? 0}"
             }
         );
         yield return new TestCaseData(
-            "/overrideconfig tag-prefix=sample /overrideconfig assembly-versioning-format=\"{Major}.{Minor}.{Patch}.{env:CI_JOB_ID ?? 0}\" /overrideconfig update-build-number=true /overrideconfig assembly-versioning-scheme=MajorMinorPatchTag /overrideconfig mode=ContinuousDelivery /overrideconfig tag-pre-release-weight=4",
+            "--override-config tag-prefix=sample --override-config assembly-versioning-format=\"{Major}.{Minor}.{Patch}.{env:CI_JOB_ID ?? 0}\" --override-config update-build-number=true --override-config assembly-versioning-scheme=MajorMinorPatchTag --override-config mode=ContinuousDelivery --override-config tag-pre-release-weight=4",
             new GitVersionConfiguration
             {
                 TagPrefixPattern = "sample",
@@ -711,7 +711,7 @@ public void LogPathCanContainForwardSlash()
     [Test]
     public void BooleanArgumentHandling()
     {
-        var arguments = this.argumentParser.ParseArguments("/nofetch /updateassemblyinfo true");
+        var arguments = this.argumentParser.ParseArguments("--no-fetch --update-assembly-info true");
         arguments.NoFetch.ShouldBe(true);
         arguments.UpdateAssemblyInfo.ShouldBe(true);
     }

src/GitVersion.App/SpectreArgumentParser.cs

@@ -90,161 +90,8 @@ public Arguments ParseArguments(string[] commandLineArguments)
         }
         catch (Exception)
         {
-            // If parsing fails, try to handle legacy forward slash syntax
-            return HandleLegacySyntax(commandLineArguments);
-        }
-        
-        return CreateDefaultArguments();
-    }
-
-    private Arguments HandleLegacySyntax(string[] commandLineArguments)
-    {
-        // Convert legacy forward slash syntax to hyphen syntax for Spectre.Console.Cli
-        var convertedArgs = new List<string>();
-        
-        for (int i = 0; i < commandLineArguments.Length; i++)
-        {
-            var arg = commandLineArguments[i];
-            
-            // Handle legacy forward slash options
-            if (arg.StartsWith('/'))
-            {
-                var option = arg.Substring(1).ToLowerInvariant();
-                switch (option)
-                {
-                    case "output":
-                        convertedArgs.Add("--output");
-                        break;
-                    case "outputfile":
-                        convertedArgs.Add("--output-file");
-                        break;
-                    case "showvariable":
-                        convertedArgs.Add("--show-variable");
-                        break;
-                    case "format":
-                        convertedArgs.Add("--format");
-                        break;
-                    case "l":
-                        convertedArgs.Add("--log-file");
-                        break;
-                    case "config":
-                        convertedArgs.Add("--config");
-                        break;
-                    case "showconfig":
-                        convertedArgs.Add("--show-config");
-                        break;
-                    case "overrideconfig":
-                        convertedArgs.Add("--override-config");
-                        // Handle the key=value format for override config
-                        if (i + 1 < commandLineArguments.Length)
-                        {
-                            var nextArg = commandLineArguments[i + 1];
-                            if (nextArg.Contains('=') && !nextArg.StartsWith('/') && !nextArg.StartsWith('-'))
-                            {
-                                // This is the key=value pair for override config
-                                convertedArgs.Add(nextArg);
-                                i++; // Skip the next argument since we consumed it
-                            }
-                        }
-                        break;
-                    case "nocache":
-                        convertedArgs.Add("--no-cache");
-                        break;
-                    case "nonormalize":
-                        convertedArgs.Add("--no-normalize");
-                        break;
-                    case "allowshallow":
-                        convertedArgs.Add("--allow-shallow");
-                        break;
-                    case "verbosity":
-                        convertedArgs.Add("--verbosity");
-                        break;
-                    case "updateassemblyinfo":
-                        convertedArgs.Add("--update-assembly-info");
-                        break;
-                    case "updateprojectfiles":
-                        convertedArgs.Add("--update-project-files");
-                        break;
-                    case "ensureassemblyinfo":
-                        convertedArgs.Add("--ensure-assembly-info");
-                        break;
-                    case "updatewixversionfile":
-                        convertedArgs.Add("--update-wix-version-file");
-                        break;
-                    case "url":
-                        convertedArgs.Add("--url");
-                        break;
-                    case "b":
-                        convertedArgs.Add("--branch");
-                        break;
-                    case "u":
-                        convertedArgs.Add("--username");
-                        break;
-                    case "p":
-                        convertedArgs.Add("--password");
-                        break;
-                    case "c":
-                        convertedArgs.Add("--commit");
-                        break;
-                    case "dynamicrepolocation":
-                        convertedArgs.Add("--dynamic-repo-location");
-                        break;
-                    case "nofetch":
-                        convertedArgs.Add("--no-fetch");
-                        break;
-                    case "targetpath":
-                        convertedArgs.Add("--target-path");
-                        break;
-                    case "diag":
-                        convertedArgs.Add("--diag");
-                        break;
-                    default:
-                        // Unknown option, keep as is
-                        convertedArgs.Add(arg);
-                        break;
-                }
-            }
-            else if (!arg.StartsWith('-') && i == 0)
-            {
-                // First non-option argument is likely the target path
-                convertedArgs.Add(arg);
-            }
-            else
-            {
-                // Regular argument or already in correct format
-                convertedArgs.Add(arg);
-            }
-        }
-        
-        // Try parsing again with converted arguments
-        try
-        {
-            var app = new CommandApp<GitVersionCommand>();
-            app.Configure(config =>
-            {
-                config.SetApplicationName("gitversion");
-                config.PropagateExceptions();
-            });
-
-            var resultStorage = new ParseResultStorage();
-            var interceptor = new ArgumentInterceptor(resultStorage, this.environment, this.fileSystem, this.buildAgent, this.console, this.globbingResolver);
-            app.Configure(config => config.Settings.Interceptor = interceptor);
-
-            var parseResult = app.Run(convertedArgs.ToArray());
-            
-            var result = resultStorage.GetResult();
-            if (result != null)
-            {
-                return result;
-            }
-        }
-        catch (Exception)
-        {
-            // Final fallback - if it's a single argument and not an option, treat as target path
-            if (commandLineArguments.Length == 1 && !commandLineArguments[0].StartsWith('-') && !commandLineArguments[0].StartsWith('/'))
-            {
-                return CreateArgumentsWithTargetPath(commandLineArguments[0]);
-            }
+            // If parsing fails, return default arguments
+            return CreateDefaultArguments();
         }
 
         return CreateDefaultArguments();
@@ -262,18 +109,6 @@ private Arguments CreateDefaultArguments()
         return args;
     }
 
-    private Arguments CreateArgumentsWithTargetPath(string targetPath)
-    {
-        var args = new Arguments
-        {
-            TargetPath = targetPath.TrimEnd('/', '\\')
-        };
-        args.Output.Add(OutputType.Json);
-        AddAuthentication(args);
-        args.NoFetch = this.buildAgent.PreventFetch();
-        return args;
-    }
-
     private void AddAuthentication(Arguments arguments)
     {
         var username = this.environment.GetEnvironmentVariable("GITVERSION_REMOTE_USERNAME");
@@ -437,12 +272,24 @@ private static Arguments ConvertToArguments(GitVersionSettings settings)
         // Handle override configuration
         if (settings.OverrideConfiguration != null && settings.OverrideConfiguration.Any())
         {
-            var overrideConfig = new Dictionary<object, object?>();
+            var parser = new OverrideConfigurationOptionParser();
+            
             foreach (var kvp in settings.OverrideConfiguration)
             {
-                overrideConfig[kvp.Key] = kvp.Value;
+                // Validate the key format - Spectre.Console.Cli should have already parsed key=value correctly
+                // but we still need to validate against supported properties
+                var keyValueOption = $"{kvp.Key}={kvp.Value}";
+                
+                var optionKey = kvp.Key.ToLowerInvariant();
+                if (!OverrideConfigurationOptionParser.SupportedProperties.Contains(optionKey))
+                {
+                    throw new WarningException($"Could not parse --override-config option: {keyValueOption}. Unsupported 'key'.");
+                }
+                
+                parser.SetValue(optionKey, kvp.Value);
             }
-            arguments.OverrideConfiguration = overrideConfig;
+            
+            arguments.OverrideConfiguration = parser.GetOverrideConfiguration();
         }
         else
         {