Gitee.com support

[maikebing]

Gitee.com is a code hosting platform launched by OSCHINA.NET, supports Git and SVN, and offers free private repository hosting. More than 8 million developers currently choose Gitee, which is the most used Git repository hosting provider in China.

[dscho]

It is great to see this effort!

To make things easier to review (and we really want to make sure that it is well-reviewed, this program is highly security-relevant, after all), I would recommend to break things up into as-easily-reviewable pieces as possible.

[ldennington]

Overall, this looks very nice, and works well with my local testing (which, albeit, I limited to macOS). I have a few workflow notes, though:

1. Typically you will not merge to GitCredentialManager:main from the main branch of your fork. For this PR, it's fine, but in the future (likely before you start working), you will want to create a new branch locally by running git branch <branch name> while on main and then merge that branch.
2. I'm still seeing some updated GUIDs in the solution file, as originally called out by @dscho. Were those changed purposefully?
3. I see a couple of your commit messages are in Chinese. If you could change them to English, it would be much appreciated. You can use these instructions to learn how to do an interactive rebase in order to update your commit messages.

[maikebing]

1. Typically you will not merge to GitCredentialManager:main from the main branch of your fork. For this PR, it's fine, but in the future (likely before you start working), you will want to create a new branch locally by running git branch <branch name> while on main and then merge that branch.

Thanks for the tip,

2. I'm still seeing some updated GUIDs in the solution file, as originally called out by @dscho. Were those changed purposefully?

I've modified the solution.

3. I see a couple of your commit messages are in Chinese. If you could change them to English, it would be much appreciated. You can use these instructions to learn how to do an interactive rebase in order to update your commit messages.

I've made the changes and pushed them

After the New Year's holidays, take time to review the code. Thank.

@ldennington

[hickford]

Explicit port shouldn't be necessary, assuming the server correctly implements OAuth RFC 8252

The authorization server MUST allow any port to be specified at the time of the request for loopback IP redirect URIs

Have you reported a bug to Gitee?

[maikebing]

Already reported! After the Chinese New Year holiday, I will keep in touch with Gitee.Com .

[hickford]

Brilliant, thanks for reporting

[hickford]

@maikebing any news?

[hickford]

Nice work @maikebing ! I wasn't previously familiar with https://gitee.com

If it helps anyone, you can also use https://github.com/hickford/git-credential-oauth with the following .gitconfig:

[credential "https://gitee.com"]
	oauthClientId = b5da229f85d94f5d728c43e429c69527fe2dcc387d4ffcb677b91c93983adaa3
	oauthClientSecret = a9f88c722f66e54184204efa0f49b960f2666947e0b14bd0d73a8c9c1c33c340
	oauthScopes = projects gists
	oauthAuthURL = /oauth/authorize
	oauthTokenURL = /oauth/token
	# workaround server confused by random ports
	oauthRedirectURL = http://127.0.0.1:53119

[mjcheetham]

Hello @maikebing!

Thanks for your PR here! Given the number of different requests we've had over time to add OAuth-based support for new Git hosts/forges, we'd been planning to extend the generic provider to also support OAuth authentication. We plan to have this completed by the next Git release (2.40).

In light of this we won't be accepting this PR or others to add OAuth-based Git hosts. Thank you again for your contribution, we love to see such great engagement.

#1047