fix: reflect channel config besides user permissions in AttachmentSelector #2824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2824 +/- ##
==========================================
+ Coverage 81.38% 81.42% +0.04%
==========================================
Files 490 490
Lines 9932 9935 +3
Branches 2259 2260 +1
==========================================
+ Hits 8083 8090 +7
+ Misses 1738 1734 -4
Partials 111 111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Size Change: +72 B (+0.01%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
Sep 12, 2025
MartinCupela
deleted the
fix/reflect-channel-config-in-attachment-selector
branch
github-actions bot
pushed a commit
that referenced
this pull request
Sep 15, 2025
## [13.6.5](v13.6.4...v13.6.5) (2025-09-15) ### Bug Fixes * reflect channel config besides user permissions in AttachmentSelector ([#2824](#2824)) ([6e0a6e6](6e0a6e6))
|
🎉 This PR is included in version 13.6.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
When displaying the attachment selector menu, the buttons to create a new poll, upload files, share location were displayed based on user permissions only, but we were not checking if the feature as a whole was enabled (
channel.config)With this PR we check both permissions and feature enablement.
Fixes REACT-576