Skip to content

fix: prevent panic by closing channel in NewSourceTube goroutine #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Mar 12, 2024
Merged

fix: prevent panic by closing channel in NewSourceTube goroutine #156

merged 24 commits into from
Mar 12, 2024

Conversation

wyyolo
Copy link
Contributor

@wyyolo wyyolo commented Mar 3, 2024 •
edited
Loading

This PR resolves #150
Add unit test for NewSourceTube and NewSinkTube.

wyyolo and others added 18 commits February 17, 2024 22:30
@wyyolo
Method of modifying ctx to add value
c91c01e
@wyyolo
Method of modifying ctx to add value
70a8d4f
@wyyolo
Method of modifying ctx to add value
70e45b8
@wyyolo
Remove type conversions and modify function names
a4a36ec
@wyyolo
Merge branch 'FunctionStream:main' into main
7a4273e
@wyyolo
Merge branch 'FunctionStream:main' into mymain
3cc2a76
@wyyolo
Merge branch 'FunctionStream:main' into mymain
e6572f7
@wyyolo
Merge branch 'FunctionStream:main' into mymain
1e35053
@wyyolo
fix NewSinkTube in memory
5b4b055
@wyyolo
fix NewSinkTube in memory
1a8cf24
@wyyolo
fix NewSinkTube in memory
766ffaf
@wyyolo
fix NewSinkTube in memory
1301137
@wyyolo
fix NewSinkTube in memory, add unit test for NewSourceTube and NewSin…
16878cf 
…kTube.
@wyyolo
fix NewSinkTube in memory, add unit test for NewSourceTube and NewSin…
80593e6 
…kTube.
@wyyolo
fix NewSinkTube in memory, add unit test for NewSourceTube and NewSin…
c709c8b 
…kTube.
@wyyolo
fix NewSinkTube in memory, add unit test for NewSourceTube and NewSin…
9960d20 
…kTube.
@wyyolo
fix NewSinkTube in memory, add unit test for NewSourceTube and NewSin…
c28d228 
…kTube.
@wyyolo
fix NewSinkTube in memory, add unit test for NewSourceTube and NewSin…
0a7988e 
…kTube.
@wyyolo
Copy link
Contributor Author

wyyolo commented Mar 4, 2024 •
edited
Loading

16878cf: "DATA RACE" was found in TestNewSinkTube, so I added mutex to this commit(0a7988e) to protect resource access.

RobertIndie
RobertIndie reviewed Mar 4, 2024
View reviewed changes
RobertIndie
RobertIndie reviewed Mar 8, 2024
View reviewed changes
@RobertIndie RobertIndie changed the title fix : Closing the "result" within the goroutine of NewSinkTube may potentially cause a panic. fix : closing the channel within the goroutine of NewSourceTube may cause a panic. Mar 12, 2024
@RobertIndie RobertIndie changed the title fix : closing the channel within the goroutine of NewSourceTube may cause a panic. fix: prevent panic by closing channel in NewSourceTube goroutine Mar 12, 2024
@RobertIndie RobertIndie merged commit ac28d4a into FunctionStream:main Mar 12, 2024
@wyyolo wyyolo deleted the Fix branch March 12, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobertIndie RobertIndie RobertIndie approved these changes

Assignees

@wyyolo wyyolo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiple closes on the same result channle in MemoryQueueFactory

2 participants

@wyyolo @RobertIndie