Skip to content

Commit 462f0b5

Browse files
authored
New failing test management using Jupiter extension (#4696)
1 parent ecce4cc commit 462f0b5

37 files changed

+122
-40
lines changed
Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1-
package com.fasterxml.jackson.failing;
1+
package com.fasterxml.jackson.databind.tofix;
22

33
import com.fasterxml.jackson.databind.ObjectMapper;
44
import com.fasterxml.jackson.databind.testutil.DatabindTestUtil;
5+
import com.fasterxml.jackson.databind.testutil.failure.JacksonTestFailureExpected;
6+
57
import org.junit.jupiter.api.Test;
68

79
import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -17,6 +19,7 @@ record MyRecord(String first) { }
1719

1820
private final ObjectMapper mapper = newJsonMapper();
1921

22+
@JacksonTestFailureExpected
2023
@Test
2124
void testDuplicatePropertyDeserialization() throws Exception {
2225
final String json = a2q("{'first':'value','first':'value2'}");
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.fasterxml.jackson.databind.failing;
1+
package com.fasterxml.jackson.databind.tofix;
22

33
import java.util.Collections;
44

@@ -7,6 +7,7 @@
77
import com.fasterxml.jackson.databind.*;
88
import com.fasterxml.jackson.databind.records.RecordUpdate3079Test;
99
import com.fasterxml.jackson.databind.testutil.DatabindTestUtil;
10+
import com.fasterxml.jackson.databind.testutil.failure.JacksonTestFailureExpected;
1011

1112
import static org.junit.jupiter.api.Assertions.*;
1213

@@ -17,6 +18,7 @@ public class RecordUpdate3079FailingTest extends DatabindTestUtil
1718
private final ObjectMapper MAPPER = newJsonMapper();
1819

1920
// [databind#3079]: Should be able to Record value directly
21+
@JacksonTestFailureExpected
2022
@Test
2123
public void testDirectRecordUpdate() throws Exception
2224
{

src/test/java/com/fasterxml/jackson/failing/AnyGetterSorting518Test.java renamed to src/test/java/com/fasterxml/jackson/databind/tofix/AnyGetterSorting518Test.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1-
package com.fasterxml.jackson.failing;
1+
package com.fasterxml.jackson.databind.tofix;
22

33
import java.util.HashMap;
44
import java.util.LinkedHashMap;
55
import java.util.Map;
66

7+
import com.fasterxml.jackson.databind.testutil.failure.JacksonTestFailureExpected;
78
import org.junit.jupiter.api.Test;
89

910
import com.fasterxml.jackson.annotation.JsonAnyGetter;
@@ -43,6 +44,7 @@ public Bean(int a, int b, Map<String,Object> x) {
4344

4445
private final ObjectMapper MAPPER = newJsonMapper();
4546

47+
@JacksonTestFailureExpected
4648
@Test
4749
void anyBeanWithSort() throws Exception
4850
{

src/test/java/com/fasterxml/jackson/failing/AnySetterAsCreatorFallback1401Test.java renamed to src/test/java/com/fasterxml/jackson/databind/tofix/AnySetterAsCreatorFallback1401Test.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
package com.fasterxml.jackson.failing;
1+
package com.fasterxml.jackson.databind.tofix;
22

3+
import com.fasterxml.jackson.databind.testutil.failure.JacksonTestFailureExpected;
34
import org.junit.jupiter.api.Test;
45

56
import com.fasterxml.jackson.annotation.JsonAnySetter;
@@ -36,6 +37,7 @@ public void any(String key, Object value) { }
3637
private final ObjectMapper MAPPER = newJsonMapper();
3738

3839
// [databind#1401]
40+
@JacksonTestFailureExpected
3941
@Test
4042
void creatorNoSetter() throws Exception
4143
{

src/test/java/com/fasterxml/jackson/failing/AsEmptyPOJONoDefaultCtor2572Test.java renamed to src/test/java/com/fasterxml/jackson/databind/tofix/AsEmptyPOJONoDefaultCtor2572Test.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
package com.fasterxml.jackson.failing;
1+
package com.fasterxml.jackson.databind.tofix;
22

33
import java.util.Objects;
44

5+
import com.fasterxml.jackson.databind.testutil.failure.JacksonTestFailureExpected;
56
import org.junit.jupiter.api.Test;
67

78
import com.fasterxml.jackson.annotation.*;
@@ -34,6 +35,7 @@ public Inner(@JsonProperty("field") String field) {
3435
}
3536

3637
// [databind#2572]
38+
@JacksonTestFailureExpected
3739
@Test
3840
void emptyForTypeThatCannotBeInstantiated() throws Exception {
3941
ObjectMapper mapper = jsonMapperBuilder()

src/test/java/com/fasterxml/jackson/failing/BackReference1516Test.java renamed to src/test/java/com/fasterxml/jackson/databind/tofix/BackReference1516Test.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
package com.fasterxml.jackson.failing;
1+
package com.fasterxml.jackson.databind.tofix;
22

33
import java.beans.ConstructorProperties;
44

5+
import com.fasterxml.jackson.databind.testutil.failure.JacksonTestFailureExpected;
56
import org.junit.jupiter.api.Test;
67

78
import com.fasterxml.jackson.annotation.JsonBackReference;
@@ -74,6 +75,7 @@ public ChildObject2(String id, String name,
7475
" 'child': { 'id': 'def', 'name':'Bert' }\n" +
7576
"}");
7677

78+
@JacksonTestFailureExpected
7779
@Test
7880
void withParentCreator() throws Exception {
7981
ParentWithCreator result = MAPPER.readValue(PARENT_CHILD_JSON,

src/test/java/com/fasterxml/jackson/failing/BuilderWithBackRef2686Test.java renamed to src/test/java/com/fasterxml/jackson/databind/tofix/BuilderWithBackRef2686Test.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
package com.fasterxml.jackson.failing;
1+
package com.fasterxml.jackson.databind.tofix;
22

33
import java.beans.ConstructorProperties;
44

5+
import com.fasterxml.jackson.databind.testutil.failure.JacksonTestFailureExpected;
56
import org.junit.jupiter.api.Test;
67

78
import com.fasterxml.jackson.annotation.JsonBackReference;
@@ -90,6 +91,7 @@ Content build() {
9091

9192
private final ObjectMapper MAPPER = newJsonMapper();
9293

94+
@JacksonTestFailureExpected
9395
@Test
9496
void buildWithBackRefs2686() throws Exception {
9597
Container container = new Container();

src/test/java/com/fasterxml/jackson/failing/CreatorFallback2438Test.java renamed to src/test/java/com/fasterxml/jackson/databind/tofix/CreatorFallback2438Test.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.fasterxml.jackson.failing;
1+
package com.fasterxml.jackson.databind.tofix;
22

33
import org.junit.jupiter.api.Test;
44

@@ -7,6 +7,7 @@
77

88
import com.fasterxml.jackson.databind.ObjectMapper;
99
import com.fasterxml.jackson.databind.testutil.DatabindTestUtil;
10+
import com.fasterxml.jackson.databind.testutil.failure.JacksonTestFailureExpected;
1011

1112
import static org.junit.jupiter.api.Assertions.assertEquals;
1213

@@ -33,6 +34,7 @@ public void setValue(int v) {
3334

3435
private final ObjectMapper MAPPER = newJsonMapper();
3536

37+
@JacksonTestFailureExpected
3638
@Test
3739
void creator2438() throws Exception {
3840
// note: by default, duplicate-detection not enabled, so should not

src/test/java/com/fasterxml/jackson/failing/CustomObjectKeyDeserializer4680Test.java renamed to src/test/java/com/fasterxml/jackson/databind/tofix/CustomObjectKeyDeserializer4680Test.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.fasterxml.jackson.failing;
1+
package com.fasterxml.jackson.databind.tofix;
22

33
import java.util.Map;
44

@@ -8,6 +8,7 @@
88
import com.fasterxml.jackson.databind.ObjectMapper;
99
import com.fasterxml.jackson.databind.json.JsonMapper;
1010
import com.fasterxml.jackson.databind.module.SimpleModule;
11+
import com.fasterxml.jackson.databind.testutil.failure.JacksonTestFailureExpected;
1112

1213
import org.junit.jupiter.api.Assertions;
1314
import org.junit.jupiter.api.Test;
@@ -16,6 +17,7 @@
1617
public class CustomObjectKeyDeserializer4680Test
1718
{
1819

20+
@JacksonTestFailureExpected
1921
@Test
2022
void testCustomKeyDeserializer()
2123
throws Exception

src/test/java/com/fasterxml/jackson/failing/DefaultTypingOverride1391Test.java renamed to src/test/java/com/fasterxml/jackson/databind/tofix/DefaultTypingOverride1391Test.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.fasterxml.jackson.failing;
1+
package com.fasterxml.jackson.databind.tofix;
22

33
import java.util.Collection;
44
import java.util.Collections;
@@ -10,6 +10,7 @@
1010
import com.fasterxml.jackson.databind.json.JsonMapper;
1111
import com.fasterxml.jackson.databind.testutil.DatabindTestUtil;
1212
import com.fasterxml.jackson.databind.testutil.NoCheckSubTypeValidator;
13+
import com.fasterxml.jackson.databind.testutil.failure.JacksonTestFailureExpected;
1314

1415
import static org.junit.jupiter.api.Assertions.assertEquals;
1516

@@ -25,6 +26,7 @@ static class ListWrapper {
2526
public Collection<String> stuff = Collections.emptyList();
2627
}
2728

29+
@JacksonTestFailureExpected
2830
@Test
2931
void collectionWithOverride() throws Exception {
3032
final ObjectMapper mapper = JsonMapper.builder()

0 commit comments

Comments
 (0)