Make IMPORT FOREIGN SCHEMA behave consistently

mhw · mhw · commit 32c7ee8964af · 2020-09-09T16:46:10.000+01:00
The case of the table names returned by information_schema queries depends on MySQL's `lower_case_table_names` setting. https://dev.mysql.com/doc/refman/5.7/en/charset-collation-information-schema.html suggests forcing a suitable collation to work around the issue. Fixes #202.
diff --git a/mysql_fdw.c b/mysql_fdw.c
@@ -1699,7 +1699,7 @@ mysqlImportForeignSchema(ImportForeignSchemaStmt *stmt, Oid serverOid)
 	{
 		bool		first_item = true;
 
-		appendStringInfoString(&buf, " AND t.TABLE_NAME ");
+		appendStringInfoString(&buf, " AND t.TABLE_NAME COLLATE UTF8_GENERAL_CI ");
 		if (stmt->list_type == FDW_IMPORT_SCHEMA_EXCEPT)
 			appendStringInfoString(&buf, "NOT ");
 		appendStringInfoString(&buf, "IN (");

Original file line number	Diff line number	Diff line change
`@@ -1699,7 +1699,7 @@ mysqlImportForeignSchema(ImportForeignSchemaStmt *stmt, Oid serverOid)`
`1699`	`1699`	`{`
`1700`	`1700`	`bool first_item = true;`
`1701`	`1701`
`1702`		`- appendStringInfoString(&buf, " AND t.TABLE_NAME ");`
	`1702`	`+ appendStringInfoString(&buf, " AND t.TABLE_NAME COLLATE UTF8_GENERAL_CI ");`
`1703`	`1703`	`if (stmt->list_type == FDW_IMPORT_SCHEMA_EXCEPT)`
`1704`	`1704`	`appendStringInfoString(&buf, "NOT ");`
`1705`	`1705`	`appendStringInfoString(&buf, "IN (");`