daemon/chaintopology: use struct topology for more functions, not lightningd_state

Signed-off-by: Rusty Russell <[email protected]>

Author: rustyrussell

daemon/chaintopology.c

@@ -6,6 +6,7 @@
 #include <ccan/list/list.h>
 #include <ccan/short_types/short_types.h>
 #include <ccan/structeq/structeq.h>
+#include <ccan/time/time.h>
 #include <daemon/watch.h>
 #include <stddef.h>
 
@@ -80,6 +81,18 @@ struct topology {
 	u64 feerate;
 	bool startup;
 
+	/* How far back (in blocks) to go. */
+	unsigned int first_blocknum;
+
+	/* How often to poll. */
+	struct timerel poll_time;
+
+	/* The bitcoind. */
+	struct bitcoind *bitcoind;
+
+	/* Our timer list. */
+	struct timers *timers;
+
 	/* Bitcoin transctions we're broadcasting */
 	struct list_head outgoing_txs;
 
@@ -100,32 +113,37 @@ struct txlocator {
 
 /* This is the number of blocks which would have to be mined to invalidate
  * the tx. */
-size_t get_tx_depth(struct lightningd_state *dstate,
+size_t get_tx_depth(const struct topology *topo,
 		    const struct sha256_double *txid);
 
 /* Get the mediantime of the block including this tx (must be one!) */
-u32 get_tx_mediantime(struct lightningd_state *dstate,
+u32 get_tx_mediantime(const struct topology *topo,
 		      const struct sha256_double *txid);
 
 /* Get mediantime of the tip; if more than one, pick greatest time. */
-u32 get_tip_mediantime(struct lightningd_state *dstate);
+u32 get_tip_mediantime(const struct topology *topo);
 
 /* Get highest block number. */
-u32 get_block_height(struct lightningd_state *dstate);
+u32 get_block_height(const struct topology *topo);
 
 /* Get fee rate. */
 u64 get_feerate(struct lightningd_state *dstate);
 
 /* Broadcast a single tx, and rebroadcast as reqd (copies tx).
  * If failed is non-NULL, call that and don't rebroadcast. */
-void broadcast_tx(struct peer *peer, const struct bitcoin_tx *tx,
+void broadcast_tx(struct topology *topo,
+		  struct peer *peer, const struct bitcoin_tx *tx,
 		  void (*failed)(struct peer *peer,
 				 int exitstatus,
 				 const char *err));
 
 struct topology *new_topology(const tal_t *ctx);
-void setup_topology(struct topology *topology, struct bitcoind *bitcoind);
+void setup_topology(struct topology *topology, struct bitcoind *bitcoind,
+		    struct timers *timers,
+		    struct timerel poll_time, u32 first_peer_block);
+
+struct txlocator *locate_tx(const void *ctx, const struct topology *topo, const struct sha256_double *txid);
 
-struct txlocator *locate_tx(const void *ctx, struct lightningd_state *dstate, const struct sha256_double *txid);
+void notify_new_block(struct topology *topo, unsigned int height);
 
 #endif /* LIGHTNING_DAEMON_CRYPTOPKT_H */

daemon/chaintopology.h

@@ -28,7 +28,7 @@ static bool announce_channel(const tal_t *ctx, struct ircstate *state, struct pe
 {
 	char txid[65];
 	struct privmsg *msg = talz(ctx, struct privmsg);
-	struct txlocator *loc = locate_tx(ctx, state->dstate, &p->anchor.txid);
+	struct txlocator *loc = locate_tx(ctx, state->dstate->topology, &p->anchor.txid);
 
 	if (loc == NULL)
 		return false;

daemon/irc_announce.c

@@ -275,7 +275,8 @@ static void json_getinfo(struct command *cmd,
 		json_add_num(response, "port", cmd->dstate->portnum);
 	json_add_bool(response, "testnet", cmd->dstate->testnet);
 	json_add_string(response, "version", version());
-	json_add_num(response, "blockheight", get_block_height(cmd->dstate));
+	json_add_num(response, "blockheight",
+		     get_block_height(cmd->dstate->topology));
 	json_object_end(response);
 	command_success(cmd, response);
 }

daemon/jsonrpc.c

@@ -66,8 +66,8 @@ int main(int argc, char *argv[])
 	secp256k1_ctx = secp256k1_context_create(SECP256K1_CONTEXT_VERIFY
 						 | SECP256K1_CONTEXT_SIGN);
 
-	dstate->bitcoind = new_bitcoind(dstate, dstate->base_log);
 	dstate->topology = new_topology(dstate);
+	dstate->bitcoind = new_bitcoind(dstate, dstate->base_log);
 
 	/* Handle options and config; move to .lightningd */
 	register_opts(dstate);
@@ -87,7 +87,9 @@ int main(int argc, char *argv[])
 	db_init(dstate);
 
 	/* Initialize block topology. */
-	setup_topology(dstate->topology, dstate->bitcoind);
+	setup_topology(dstate->topology, dstate->bitcoind, &dstate->timers,
+		       dstate->config.poll_time,
+		       get_peer_min_block(dstate));
 
 	/* Create RPC socket (if any) */
 	setup_jsonrpc(dstate, dstate->rpc_filename);

daemon/lightningd.c

@@ -22,7 +22,7 @@ static void broadcast_channel_update(struct lightningd_state *dstate, struct pee
 	u32 timestamp = time_now().ts.tv_sec;
 	const tal_t *tmpctx = tal_tmpctx(dstate);
 
-	loc = locate_tx(tmpctx, dstate, &peer->anchor.txid);
+	loc = locate_tx(tmpctx, dstate->topology, &peer->anchor.txid);
 	channel_id.blocknum = loc->blkheight;
 	channel_id.txnum = loc->index;
 	channel_id.outnum = peer->anchor.index;
@@ -105,7 +105,7 @@ static void broadcast_channel_announcement(struct lightningd_state *dstate, stru
 	u8 *serialized;
 	const tal_t *tmpctx = tal_tmpctx(dstate);
 
-	loc = locate_tx(tmpctx, dstate, &peer->anchor.txid);
+	loc = locate_tx(tmpctx, dstate->topology, &peer->anchor.txid);
 
 	channel_id.blocknum = loc->blkheight;
 	channel_id.txnum = loc->index;

daemon/p2p_announce.c

@@ -462,7 +462,8 @@ static void json_sendpay(struct command *cmd,
 
 	/* Expiry for HTLCs is absolute.  And add one to give some margin. */
 	err = command_htlc_add(peer, amount,
-			       delay + get_block_height(cmd->dstate) + 1,
+			       delay + get_block_height(cmd->dstate->topology)
+			       + 1,
 			       &rhash, NULL,
 			       onion, &error_code, &pc->htlc);
 	if (err) {

daemon/pay.c

@@ -347,14 +347,15 @@ static void peer_breakdown(struct peer *peer)
 	if (peer->closing.their_sig) {
 		const struct bitcoin_tx *close = mk_bitcoin_close(peer, peer);
 		log_unusual(peer->log, "Peer breakdown: sending close tx");
-		broadcast_tx(peer, close, NULL);
+		broadcast_tx(peer->dstate->topology, peer, close, NULL);
 		tal_free(close);
 	/* If we have a signed commit tx (maybe not if we just offered
 	 * anchor, or they supplied anchor, or no outputs to us). */
 	} else if (peer->local.commit && peer->local.commit->sig) {
 		log_unusual(peer->log, "Peer breakdown: sending commit tx");
 		sign_commit_tx(peer);
-		broadcast_tx(peer, peer->local.commit->tx, NULL);
+		broadcast_tx(peer->dstate->topology, peer,
+			     peer->local.commit->tx, NULL);
 	} else {
 		log_info(peer->log, "Peer breakdown: nothing to do");
 		/* We close immediately. */
@@ -644,7 +645,8 @@ static bool open_ouranchor_pkt_in(struct peer *peer, const Pkt *pkt)
 	if (db_commit_transaction(peer) != NULL)
 		return peer_database_err(peer);
 
-	broadcast_tx(peer, peer->anchor.tx, funding_tx_failed);
+	broadcast_tx(peer->dstate->topology,
+		     peer, peer->anchor.tx, funding_tx_failed);
 	peer_watch_anchor(peer, peer->local.mindepth);
 	return true;
 }
@@ -878,7 +880,7 @@ static void their_htlc_added(struct peer *peer, struct htlc *htlc,
 	}
 
 	if (abs_locktime_to_blocks(&htlc->expiry) <=
-	    get_block_height(peer->dstate) + peer->dstate->config.min_htlc_expiry) {
+	    get_block_height(peer->dstate->topology) + peer->dstate->config.min_htlc_expiry) {
 		log_unusual(peer->log, "HTLC %"PRIu64" expires too soon:"
 			    " block %u",
 			    htlc->id, abs_locktime_to_blocks(&htlc->expiry));
@@ -888,7 +890,7 @@ static void their_htlc_added(struct peer *peer, struct htlc *htlc,
 	}
 
 	if (abs_locktime_to_blocks(&htlc->expiry) >
-	    get_block_height(peer->dstate) + peer->dstate->config.max_htlc_expiry) {
+	    get_block_height(peer->dstate->topology) + peer->dstate->config.max_htlc_expiry) {
 		log_unusual(peer->log, "HTLC %"PRIu64" expires too far:"
 			    " block %u",
 			    htlc->id, abs_locktime_to_blocks(&htlc->expiry));
@@ -1313,7 +1315,7 @@ static bool closing_pkt_in(struct peer *peer, const Pkt *pkt)
 		 * SHOULD sign and broadcast the final closing transaction.
 		 */
 		close = mk_bitcoin_close(peer, peer);
-		broadcast_tx(peer, close, NULL);
+		broadcast_tx(peer->dstate->topology, peer, close, NULL);
 		tal_free(close);
 		return false;
 	}
@@ -2058,7 +2060,8 @@ static bool fulfill_onchain(struct peer *peer, struct htlc *htlc)
 				return false;
 			peer->onchain.resolved[i]
 				= htlc_fulfill_tx(peer, i);
-			broadcast_tx(peer, peer->onchain.resolved[i], NULL);
+			broadcast_tx(peer->dstate->topology,
+				     peer, peer->onchain.resolved[i], NULL);
 			return true;
 		}
 	}
@@ -2106,14 +2109,14 @@ const char *command_htlc_add(struct peer *peer, u64 msatoshi,
 		return "bad expiry";
 	}
 
-	if (expiry < get_block_height(peer->dstate) + peer->dstate->config.min_htlc_expiry) {
+	if (expiry < get_block_height(peer->dstate->topology) + peer->dstate->config.min_htlc_expiry) {
 		log_unusual(peer->log, "add_htlc: fail: expiry %u is too soon",
 			    expiry);
 		*error_code = BAD_REQUEST_400;
 		return "expiry too soon";
 	}
 
-	if (expiry > get_block_height(peer->dstate) + peer->dstate->config.max_htlc_expiry) {
+	if (expiry > get_block_height(peer->dstate->topology) + peer->dstate->config.max_htlc_expiry) {
 		log_unusual(peer->log, "add_htlc: fail: expiry %u is too far",
 			    expiry);
 		*error_code = BAD_REQUEST_400;
@@ -2842,7 +2845,7 @@ static bool peer_first_connected(struct peer *peer,
 	peer->conn = conn;
 	io_set_finish(conn, peer_disconnect, peer);
 
-	peer->anchor.min_depth = get_block_height(peer->dstate);
+	peer->anchor.min_depth = get_block_height(peer->dstate->topology);
 
 	/* FIXME: Attach IO logging for this peer. */
 	if (!netaddr_from_fd(io_conn_fd(conn), addr_type, addr_protocol, &addr))
@@ -3249,7 +3252,7 @@ AUTODATA(json_command, &connect_command);
 /* Have any of our HTLCs passed their deadline? */
 static bool any_deadline_past(struct peer *peer)
 {
-	u32 height = get_block_height(peer->dstate);
+	u32 height = get_block_height(peer->dstate->topology);
 	struct htlc_map_iter it;
 	struct htlc *h;
 
@@ -3272,7 +3275,7 @@ static bool any_deadline_past(struct peer *peer)
 
 static void check_htlc_expiry(struct peer *peer)
 {
-	u32 height = get_block_height(peer->dstate);
+	u32 height = get_block_height(peer->dstate->topology);
 	struct htlc_map_iter it;
 	struct htlc *h;
 
@@ -3400,8 +3403,9 @@ static enum watch_result anchor_depthchange(struct peer *peer,
 	return KEEP_WATCHING;
 }
 
-void peers_new_block(struct lightningd_state *dstate, unsigned int height)
+void notify_new_block(struct topology *topo, unsigned int height)
 {
+	struct lightningd_state *dstate = tal_parent(topo);
 	/* This is where we check for anchor timeouts. */
 	struct peer *peer;
 
@@ -3632,7 +3636,7 @@ static enum watch_result our_htlc_depth(struct peer *peer,
 	if (depth == 0)
 		return KEEP_WATCHING;
 
-	height = get_block_height(peer->dstate);
+	height = get_block_height(peer->dstate->topology);
 
 	/* FIXME-OLD #onchain:
 	 *
@@ -3663,7 +3667,8 @@ static enum watch_result our_htlc_depth(struct peer *peer,
 			 peer,
 			 peer->onchain.resolved[out_num],
 			 our_htlc_timeout_depth, h);
-		broadcast_tx(peer, peer->onchain.resolved[out_num], NULL);
+		broadcast_tx(peer->dstate->topology,
+			     peer, peer->onchain.resolved[out_num], NULL);
 	}
 	return DELETE_WATCH;
 }
@@ -3696,7 +3701,7 @@ static enum watch_result their_htlc_depth(struct peer *peer,
 	if (depth == 0)
 		return KEEP_WATCHING;
 
-	height = get_block_height(peer->dstate);
+	height = get_block_height(peer->dstate->topology);
 
 	/* FIXME-OLD #onchain:
 	 *
@@ -3732,7 +3737,8 @@ static enum watch_result our_main_output_depth(struct peer *peer,
 	 */
 	peer->onchain.resolved[peer->onchain.to_us_idx]
 		= bitcoin_spend_ours(peer);
-	broadcast_tx(peer, peer->onchain.resolved[peer->onchain.to_us_idx],
+	broadcast_tx(peer->dstate->topology,
+		     peer, peer->onchain.resolved[peer->onchain.to_us_idx],
 		     NULL);
 	return DELETE_WATCH;
 }
@@ -3852,7 +3858,8 @@ static void resolve_their_htlc(struct peer *peer, unsigned int out_num)
 	 */
 	if (peer->onchain.htlcs[out_num]->r) {
 		peer->onchain.resolved[out_num]	= htlc_fulfill_tx(peer, out_num);
-		broadcast_tx(peer, peer->onchain.resolved[out_num], NULL);
+		broadcast_tx(peer->dstate->topology,
+			     peer, peer->onchain.resolved[out_num], NULL);
 	} else {
 		/* FIXME-OLD #onchain:
 		 *
@@ -4012,7 +4019,7 @@ static enum watch_result check_for_resolution(struct peer *peer,
 		struct sha256_double txid;
 
 		bitcoin_txid(peer->onchain.resolved[i], &txid);
-		if (get_tx_depth(peer->dstate, &txid) < forever)
+		if (get_tx_depth(peer->dstate->topology, &txid) < forever)
 			return KEEP_WATCHING;
 	}
 
@@ -4146,7 +4153,7 @@ static void resolve_their_steal(struct peer *peer,
 	}
 	assert(n == tal_count(steal_tx->input));
 
-	broadcast_tx(peer, steal_tx, NULL);
+	broadcast_tx(peer->dstate->topology, peer, steal_tx, NULL);
 }
 
 static struct sha256 *get_rhash(struct peer *peer, u64 commit_num,
@@ -4485,6 +4492,22 @@ void reconnect_peers(struct lightningd_state *dstate)
 		try_reconnect(peer);
 }
 
+/* Return earliest block we're interested in, or 0 for none. */
+u32 get_peer_min_block(struct lightningd_state *dstate)
+{
+	u32 min_block = 0;
+	struct peer *peer;
+
+	/* If loaded from database, go back to earliest possible peer anchor. */
+	list_for_each(&dstate->peers, peer, list) {
+		if (!peer->anchor.min_depth)
+			continue;
+		if (min_block == 0 || peer->anchor.min_depth < min_block)
+			min_block = peer->anchor.min_depth;
+	}
+	return min_block;
+}
+
 /* We may have gone down before broadcasting the anchor.  Try again. */
 void rebroadcast_anchors(struct lightningd_state *dstate)
 {
@@ -4498,7 +4521,8 @@ void rebroadcast_anchors(struct lightningd_state *dstate)
 		if (!bitcoin_create_anchor(peer))
 			peer_fail(peer, __func__);
 		else
-			broadcast_tx(peer, peer->anchor.tx, NULL);
+			broadcast_tx(peer->dstate->topology,
+				     peer, peer->anchor.tx, NULL);
 	}
 }
 

daemon/peer.c

@@ -270,8 +270,6 @@ const char *command_htlc_add(struct peer *peer, u64 msatoshi,
 			     enum fail_error *error_code,
 			     struct htlc **htlc);
 
-void peers_new_block(struct lightningd_state *dstate, unsigned int height);
-
 /* Peer has an issue, breakdown and fail. */
 void peer_fail(struct peer *peer, const char *caller);
 
@@ -280,6 +278,8 @@ void peer_watch_anchor(struct peer *peer, int depth);
 struct bitcoin_tx *peer_create_close_tx(const tal_t *ctx,
 					struct peer *peer, u64 fee);
 
+u32 get_peer_min_block(struct lightningd_state *dstate);
+
 void debug_dump_peers(struct lightningd_state *dstate);
 
 void reconnect_peers(struct lightningd_state *dstate);

daemon/peer.h

@@ -221,7 +221,6 @@ void watch_topology_changed(struct topology *topo)
 	struct txwatch_hash_iter i;
 	struct txwatch *w;
 	bool needs_rerun;
-	struct lightningd_state *dstate = tal_parent(topo);
 
 again:
 	/* Iterating a htable during deletes is safe, but might skip entries. */
@@ -231,7 +230,7 @@ void watch_topology_changed(struct topology *topo)
 	     w = txwatch_hash_next(&topo->txwatches, &i)) {
 		size_t depth;
 
-		depth = get_tx_depth(dstate, &w->txid);
+		depth = get_tx_depth(topo, &w->txid);
 		if (depth != w->depth) {
 			enum watch_result r;
 			w->depth = depth;